Skip to content

feat(nextjs-insights): fixed thresholds for p95 durations #92189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented May 23, 2025

  • Frontend data is more diverse than API responses and has more outliers, therefore there are many more cases where P95>2 x avg
  • Use fixed threshold to color the P95 in the PagesTable component
  • Thresholds are inspired by Web Vitals - 2500 and 4000 milliseconds for yellow & red

Before:
Screenshot 2025-05-23 at 11 12 08

After:
Screenshot 2025-05-23 at 11 11 49

@shellmayr shellmayr requested a review from a team as a code owner May 23, 2025 09:12
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 23, 2025
Copy link

codecov bot commented May 23, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
10360 2 10358 9
View the top 2 failed test(s) by shortest run time
useReplayCount getOne & hasOne should return undefined to start, then the count after data is loaded
Stack Traces | 0.132s run time
Error: expect(received).toBe(expected) // Object.is equality

Expected: 5
Received: undefined
    at Object.<anonymous> (.../utils/replayCount/useReplayCount.spec.tsx:57:45)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
useReplayCount getMany & hasMany should return undefined to start, then the count after data is loaded
Stack Traces | 0.192s run time
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 5
+ Received  + 1

- Object {
-   "1111": 5,
-   "2222": 7,
-   "3333": 0,
- }
+ Object {}
    at Object.<anonymous> (.../utils/replayCount/useReplayCount.spec.tsx:113:64)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant