Skip to content

chore(perf-issues): Dedupe the evidence from URL parameters in experiment #92222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leeandher
Copy link
Member

Since we catch these on two dimensions now (e.g, path params change or query params change or both) we need to dedupe the evidence now. Some Examples:

example.com/user/1/data?region=1 
example.com/user/2/data?region=1  
example.com/user/3/data?region=1
> Path: [1, 2, 3]
> Old Query: [1, 1, 1]
> New Query: [1] 
example.com/user/1/data?region=1 
example.com/user/1/data?region=2  
example.com/user/1/data?region=3
> Old Path: [1, 1, 1]
> New Path: [1]
> Query: [1, 2, 3]
example.com/user/1/data?region=1 
example.com/user/2/data?region=2  
example.com/user/3/data?region=3
> Path: [1, 2, 3]
> Query: [1, 2, 3] 

@leeandher leeandher requested a review from a team as a code owner May 23, 2025 18:27
@leeandher leeandher requested a review from a team May 23, 2025 18:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 23, 2025
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92222      +/-   ##
==========================================
+ Coverage   85.57%   87.93%   +2.36%     
==========================================
  Files       10172    10174       +2     
  Lines      583350   583391      +41     
  Branches    22593    22593              
==========================================
+ Hits       499175   512991   +13816     
+ Misses      83723    69948   -13775     
  Partials      452      452              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants