tools: run eslint on mdx files #92324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
May 27, 2025
ryan953
reviewed
May 27, 2025
ryan953
reviewed
May 27, 2025
Comment on lines
+41
to
+43
| // Exclude MDX files from type-aware linting | ||
| // https://github.com/orgs/mdx-js/discussions/2454 | ||
| const MDXIgnore = ['**/*.mdx']; |
There was a problem hiding this comment.
looks like this is also used in plugin/typescript-eslint/custom which should not include type-aware rules
There was a problem hiding this comment.
I need to update the comment, it should say typescript linting.
ryan953
approved these changes
May 27, 2025
scttcper
reviewed
May 27, 2025
static/app/styles/colors.mdx
Outdated
| <figure> | ||
| export function ExampleCard({imgSrc, text, isPositive}) { | ||
| return ( | ||
| <figure> | ||
| <ExampleImg src={imgSrc} /> |
There was a problem hiding this comment.
is prettier not being applied either?
There was a problem hiding this comment.
In this PR not yet, I added it in a separate PR
TkDodo
approved these changes
May 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92324 +/- ##
==========================================
- Coverage 87.91% 86.73% -1.19%
==========================================
Files 10209 10199 -10
Lines 584833 584050 -783
Branches 22686 22643 -43
==========================================
- Hits 514185 506596 -7589
- Misses 70226 77033 +6807
+ Partials 422 421 -1 |
billyvg
pushed a commit
that referenced
this pull request
May 28, 2025
Enable eslint linting for mdx files. Currently with type aware linting disabled as MDX doesn't support TS expressions --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable eslint linting for mdx files. Currently with type aware linting disabled as MDX doesn't support TS expressions