feat(nav): Improve preview of other nav groups on hover #92352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
May 27, 2025
There was a problem hiding this comment.
This file was removed in #92055, bringing it back since we want the hover to expand behavior back.
|
|
||
| const IGNORE_ELEMENTS = [ | ||
| // Tooltips are rendered in document.body so will cause the nav to close | ||
| '[data-tooltip="true"]', |
There was a problem hiding this comment.
You probably could use data-overlay even
| @@ -74,6 +92,15 @@ const SidebarWrapper = styled('div')<{tourIsActive: boolean}>` | |||
| `} | |||
| `; | |||
|
|
|||
| const CollapsedSecondaryWrapper = styled(motion.div)` | |||
There was a problem hiding this comment.
Should this be like motion.nav or something I wonder
evanpurkhiser
approved these changes
May 28, 2025
billyvg
pushed a commit
that referenced
this pull request
May 28, 2025
- Switches back to a full-height secondary navigation when collapsed - Adds previewing of other nav groups even when the navigation is expanded - Adds some subtle animations when switching the active nav group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on #92055
CleanShot.2025-05-27.at.13.20.35.mp4