Skip to content

chore(integrations) Remove unused parameter from find_channel_id_for_rule #92356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

markstory
Copy link
Member

Previously I deprecated usage of the project parameter. With that change out safely, the formal parameter can be removed.

…rule

Previously I deprecated usage of the project parameter. With that change
out safely, the formal parameter can be removed.
@markstory markstory requested review from a team as code owners May 27, 2025 21:05
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tegrations/slack/tasks/find_channel_id_for_rule.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92356      +/-   ##
==========================================
+ Coverage   84.48%   87.92%   +3.43%     
==========================================
  Files       10208    10208              
  Lines      584577   584817     +240     
  Branches    22689    22689              
==========================================
+ Hits       493869   514177   +20308     
+ Misses      90287    70219   -20068     
  Partials      421      421              

@markstory markstory merged commit dc5165d into master May 28, 2025
62 checks passed
@markstory markstory deleted the chore-cleanup-slack-task branch May 28, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants