From 872df578c877373f6474a18df93a4505c535a8ba Mon Sep 17 00:00:00 2001 From: Mark Story Date: Tue, 27 May 2025 11:52:26 -0400 Subject: [PATCH] chore(integrations) Remove unused parameter from find_channel_id_for_rule Previously I deprecated usage of the project parameter. With that change out safely, the formal parameter can be removed. --- .../slack/tasks/find_channel_id_for_rule.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py b/src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py index 900bb7ff100587..598371c900632a 100644 --- a/src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py +++ b/src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py @@ -32,7 +32,6 @@ ), ) def find_channel_id_for_rule( - project: Project | None, actions: Sequence[dict[str, Any]], uuid: str, rule_id: int | None = None, @@ -42,13 +41,11 @@ def find_channel_id_for_rule( ) -> None: redis_rule_status = RedisRuleStatus(uuid) - if not project and project_id: - try: - project = Project.objects.get_from_cache(id=project_id) - except Project.DoesNotExist: - redis_rule_status.set_value("failed") - return - assert project, "find_channel_id_for_rule requires a project or project_id" + try: + project = Project.objects.get_from_cache(id=project_id) + except Project.DoesNotExist: + redis_rule_status.set_value("failed") + return organization = project.organization integration_id: int | None = None