Skip to content

chore(integrations) Remove unused parameter from find_channel_id_for_rule #92356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

chore(integrations) Remove unused parameter from find_channel_id_for_rule #92356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
),
)
def find_channel_id_for_rule(
project: Project | None,
actions: Sequence[dict[str, Any]],
uuid: str,
rule_id: int | None = None,
Expand All @@ -42,13 +41,11 @@ def find_channel_id_for_rule(
) -> None:
redis_rule_status = RedisRuleStatus(uuid)

if not project and project_id:
try:
project = Project.objects.get_from_cache(id=project_id)
except Project.DoesNotExist:
redis_rule_status.set_value("failed")
return
assert project, "find_channel_id_for_rule requires a project or project_id"
try:
project = Project.objects.get_from_cache(id=project_id)
except Project.DoesNotExist:
redis_rule_status.set_value("failed")
return

organization = project.organization
integration_id: int | None = None
Expand Down
Loading