chore(jira): Add more logs/expose them better #92359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92359 +/- ##
========================================
Coverage 87.91% 87.92%
========================================
Files 10217 10220 +3
Lines 585519 585678 +159
Branches 22720 22720
========================================
+ Hits 514782 514933 +151
- Misses 70309 70317 +8
Partials 428 428 |
iamrajjoshi
reviewed
May 28, 2025
| }, | ||
| ) | ||
| return | ||
| raise IntegrationFormError({"email": "Unable to find the requested user"}) |
There was a problem hiding this comment.
IntegrationFormError is generally for misconfigured ticket/sentry app forms. is there a more relevant type of error we can raise?
There was a problem hiding this comment.
From the existing exceptions I see we have we could do IntegrationInstallationConfigurationError since this usually means the user either isnt verified or put a bad email/jira user.
I can narrow down the error message to be more helpful though if the user isn;t verified on sentry's side.
iamrajjoshi
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was harder to debug the jira assignment sync issue because we swallowed the errors
This could negatively affect our SLOs but I'd rather see all the errors first and then narrow from there,