fix(taskworker) Update parameters for update_user_reports #92362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to tighten our task + pickle support to also include direct calls to task functions. The update_user_report task had several parameters that cannot be JSON encoded. I've replaced the problematic parameters with JSON compatible ones, and updated logic accordingly. While these signatures would normally be breaking changes, this task *is only* triggered from celerybeat and thus never gets any parameters.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92362 +/- ##
==========================================
- Coverage 87.92% 87.92% -0.01%
==========================================
Files 10209 10209
Lines 584831 584836 +5
Branches 22687 22687
==========================================
- Hits 514194 514191 -3
- Misses 70215 70223 +8
Partials 422 422 |
JoshFerge
approved these changes
May 28, 2025
aliu39
approved these changes
May 28, 2025
evanh
approved these changes
May 29, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
I'm trying to tighten our task + pickle support to also include direct calls to task functions. The update_user_report task had several parameters that cannot be JSON encoded. I've replaced the problematic parameters with JSON compatible ones, and updated logic accordingly. While these signatures would normally be breaking changes, this task *is only* triggered from celerybeat and thus never gets any parameters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to tighten our task + pickle support to also include direct calls to task functions. The update_user_report task had several parameters that cannot be JSON encoded. I've replaced the problematic parameters with JSON compatible ones, and updated logic accordingly.
While these signatures would normally be breaking changes, this task is only triggered from celerybeat and thus never gets any parameters.