feat(seer): Trial and checkout UI #92389
Conversation
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92389 +/- ##
==========================================
- Coverage 81.61% 81.61% -0.01%
==========================================
Files 10207 10207
Lines 584854 584853 -1
Branches 22686 22686
==========================================
- Hits 477340 477339 -1
Misses 107092 107092
Partials 422 422 |
There was a problem hiding this comment.
Looks good for a first pass to me as it looks like we're acknowledging at the same time the billing button is pressed
I'd suggest putting the seer icon next to the "Meet Seer" text rather than next to the button. Looks kinda weird there IMO and placing it next to "Meet Seer" would "introduce" you to the little guy lol
Ok, moved it |
| <Button | ||
| icon={<IconRefresh size="xs" />} | ||
| onClick={() => refetch()} | ||
| size="md" | ||
| priority="default" | ||
| aria-label={t('Refresh')} | ||
| borderless |
There was a problem hiding this comment.
putting this here in case the user adds budget so they can update the screen, because the modal doesn't have any callback or anything
| const trial = getProductTrial( | ||
| subscription?.productTrials ?? null, | ||
| DataCategory.SEER_AUTOFIX | ||
| ); |
There was a problem hiding this comment.
since it looks like we only need trial info for discerning whether to render the product trial upsell, you should use getPotentialProductTrial
| const hasSeerButNeedsPayg = | ||
| shouldShowBilling && organization.features.includes('seer-added'); | ||
|
|
||
| const isTouchCustomer = subscription?.type === BillingType.INVOICED; |
There was a problem hiding this comment.
we likely need to special case for sponsored customers too since they won't have access to seer at all
There was a problem hiding this comment.
What's the special case for them? Do they just get free unlimited access, do we tell them to talk to someone, do we just block them from using Seer...?
There was a problem hiding this comment.
It was decided sponsored orgs won't be able to use Seer but we should double check the expected behavior for them in the project channel
| requestData={{ | ||
| productTrial: { | ||
| category: DataCategory.SEER_AUTOFIX, | ||
| reasonCode: 1001, |
There was a problem hiding this comment.
| reasonCode: 1001, | |
| reasonCode: trial.reasonCode, |
| {t( | ||
| "You've run out of pay-as-you-go budget. Please add more to keep using Seer." | ||
| )} |
There was a problem hiding this comment.
| {t( | |
| "You've run out of pay-as-you-go budget. Please add more to keep using Seer." | |
| )} | |
| {tct( | |
| "You've run out of [budgetTerm] budget. Please add more to keep using Seer.", | |
| {budgetTerm: subscription.planDetails.budgetTerm} | |
| )} |
we have different names based on the plan tier 😅
| )} | ||
| </ErrorText> | ||
| <Flex> | ||
| <AddBudgetButton |
There was a problem hiding this comment.
would be great to add some analytics here!
@isabellaenriquez it's still giving me a 400, but I am making the button available by hardcoding. My condition for |
|
@roaga ah yeah that makes sense, we'll just verify this in e2e testing next week |
| @@ -50,6 +50,7 @@ function AiSetupDataConsent({groupId}: AiSetupDataConsentProps) { | |||
| shouldShowBilling && organization.features.includes('seer-added'); | |||
|
|
|||
| const isTouchCustomer = subscription?.type === BillingType.INVOICED; | |||
| const isSponsoredCustomer = subscription?.type === BillingType.PARTNER; | |||
There was a problem hiding this comment.
we should check subscription.isSponsored instead since we only want to show that messaging for orgs on sponsored plans (not all partner orgs are on sponsored plans)
| ? t('Contact your customer success manager to get access to Seer.') | ||
| : t('Seer is not available on Sponsored plans.')} |
There was a problem hiding this comment.
typically for touch customers, we'll include the sales contact email (sales@sentry.io)
would probably also be nice for the sponsored orgs to get the support contact email (support@sentry.io)
In the drawer, if the
seer-billingflag is enabled, shows buttons to start trials/go to checkout. These buttons implicitly trigger the acknowledgement check as well. If billing is satisfied and missing acknowledgement, the old acknowledgement buttons will still show.If no autofix quota in the set up check > show welcome screen > if trial available and not started, prompt to start trial, else prompt to checkout
Note: pls double check my billing logic is correct, I'm new to the code here. in
yarn dev-uiI was getting a 400 when clicking "start trial" for example but I'm hoping that's just because billing hasn't released yet or because i'm testing locally.