ref(insights): migrate screen load charts to widget platform #92491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches from using non-split enhancements (and sometimes also calculating split enhancements) to just using the split enhancements. In the time since the experiment was enabled, across over 150 million events, the results of the split enhancements have matched* those of the non-split ones, and the split enhancements have been running on average about 45% faster than the non-split ones. (See #92180 for a graph comparing the average times.) * To be more precise, they have matched except in cases where the split enhancements have given different/better hints, in ways we expect: - Because the rules are split, hints about marking things in-app or out of app only include the `+/-app` part of the rule, and hints about ignoring/unignoring only include the `+/-group` part. - In cases where both an in-app and contributes change have happened, both are now included in the hint. This can be seen in the snapshot changes included in this PR.
…get library (#92484) 1. convert app starts "average cold start" widget to use the standard widget, this makes it easy to add open in explore functionality directly from the chart, and has benefits like full screen mode <img width="613" alt="image" src="https://github.com/user-attachments/assets/6fc9a195-6596-4697-b99d-fd09b3b61d06" /> 2. Add a `none` option to the `showReleaseAs` prop in the widget. Release bubbles aren't supported in mobile because the data is explicitly filtered by two releases, therefore it doesn't make sense to overlay all releases. 3. Add `always` option to `showLegend`. Originally the legend would hide when there is only one series, but there is a case where you select two releases and we only have series data for one. We wouldn't want to hide the legend in this case because you won't know which data the release pertains to.
github-actions
bot
added
Scope: Frontend
narsaynorath
approved these changes
May 30, 2025
@narsaynorath nice catch! i'll try to fix that before merging. I don't recall seeing that though, is there something specific you did to see that? (after slack discussion this was noticed on PR too, so it shouldn't block this PR) |
DominikB2014
deleted the
dominikbuszowiecki/dain-568-migrate-screen-load-charts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta, this means we can remove theOUTPUT_TYPEconstant.total countchart the same size as the others so it doesn't look too tall and over emphasized.heightprop has been adjusted in the app starts breakdown chart to accommodate some of these changes (otherwise it's not the same as the chart next to it)