-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
build(ui): Use rspack to build production #92493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
will remove webpack soon. reorders the commands a little bit
"build-production": "NODE_ENV=production webpack --mode production", | ||
"build-acceptance-webpack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack", | ||
"build-acceptance-rspack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production rspack", | ||
"build-production": "yarn build-production-rspack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo!
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
note on the package.json changes. we install packages using --production for some reason in some pipelines and we're no longer using |
PR reverted: 16d6c28 |
This reverts commit c42dc82. Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
reverting because the font path wasn't quite right and resulted in missing fonts |
will remove webpack soon. reorders the commands a little bit