Skip to content

build(ui): Use rspack to build production #92493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025

Conversation

scttcper
Copy link
Member

will remove webpack soon. reorders the commands a little bit

will remove webpack soon. reorders the commands a little bit
@scttcper scttcper requested a review from a team May 29, 2025 18:25
@scttcper scttcper requested a review from a team as a code owner May 29, 2025 18:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 29, 2025
"build-production": "NODE_ENV=production webpack --mode production",
"build-acceptance-webpack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
"build-acceptance-rspack": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production rspack",
"build-production": "yarn build-production-rspack",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 29, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@scttcper
Copy link
Member Author

scttcper commented May 29, 2025

note on the package.json changes. we install packages using --production for some reason in some pipelines and we're no longer using require to "lazy" load a few things. And then i bumped a random type patch version to get a new yarn.lock file.

@scttcper scttcper merged commit c42dc82 into master May 29, 2025
63 checks passed
@scttcper scttcper deleted the scttcper/build-production-rspack branch May 29, 2025 19:53
@scttcper scttcper added the Trigger: Revert Add to a merged PR to revert it (skips CI) label May 29, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 16d6c28

getsentry-bot added a commit that referenced this pull request May 29, 2025
This reverts commit c42dc82.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
@scttcper
Copy link
Member Author

reverting because the font path wasn't quite right and resulted in missing fonts

scttcper added a commit that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants