feat(ourlogs): Add logs to replays #92498
Conversation
Adds logs to the replays tab, querying via traceid first then fetching all logs. Closes LOGS-86
github-actions
bot
added
the
Scope: Frontend
…lays instead of having two styles temporarily.
|
@billyvg got rid of the missing borders by just excluding that side since I've split infinite scrolling up, so we only show one table now. Imported the loading and error states to show to maintain consistency. You can check now with Screenshots
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92498 +/- ##
===========================================
+ Coverage 72.82% 82.95% +10.12%
===========================================
Files 10246 10231 -15
Lines 587612 585502 -2110
Branches 22823 22703 -120
===========================================
+ Hits 427926 485680 +57754
+ Misses 158282 99400 -58882
+ Partials 1404 422 -982 |
| @@ -32,9 +36,12 @@ type Props = { | |||
| function FocusTabs({isVideoReplay}: Props) { | |||
| const organization = useOrganization(); | |||
| const {getActiveTab, setActiveTab} = useActiveReplayTab({isVideoReplay}); | |||
| const hasLogsFeature = | |||
| organization.features.includes('ourlogs-enabled') && | |||
| organization.features.includes('ourlogs-infinite-scroll'); | |||
There was a problem hiding this comment.
I don't see a ff for this, could you add the replay team so we can poke around?
There was a problem hiding this comment.
I've been using our overrides more recently rather than options automator, do you not see it?
There was a problem hiding this comment.
Ah ok, had to manually add it myself
| @@ -32,9 +36,12 @@ type Props = { | |||
| function FocusTabs({isVideoReplay}: Props) { | |||
| const organization = useOrganization(); | |||
| const {getActiveTab, setActiveTab} = useActiveReplayTab({isVideoReplay}); | |||
| const hasLogsFeature = | |||
| organization.features.includes('ourlogs-enabled') && | |||
| organization.features.includes('ourlogs-infinite-scroll'); | |||
There was a problem hiding this comment.
Ah ok, had to manually add it myself
|
@billyvg can you list them so I can track them? I'll fix them before we turn on infinite scroll |
|
Summary
Adds logs to the replays tab, querying via traceid first then fetching all logs.
Closes LOGS-86