-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(aci): Rework logic to backfill open periods #92532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration lgtm, and the logic changes seem to make sense, but I don't have too much context so it'd be good to have someone from your team confirm as well if they have more context
This PR changes the backfill logic to make sure it works with the regressed/auto-resolved cycles that tripped us up earlier. There's also a handful of cases where we see successive regressions / resolutions and the old logic didn't know how to handle that. These changes will set the open period based on the first regression/first resolution if there are multiple in a row.
Makes for an easier review if you compare against the first commit which just copies the changes from migration 0878