fix(ownership-rules): Update email filter to create less conditions #92539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to improve the performance of this filter. The current implementation creates an OR condition and calls upper on both the column and the email of the condition for each email passed. This reduces it to a single IN check and a single usage of `upper` to do the case insensitive check.
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Jun 2, 2025
narsaynorath
deleted the
nar/fix/project-ownership-large-or-condition-on-user-emails
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 3, 2025
…92539) Trying to improve the performance of this filter. The current implementation creates an OR condition and calls upper on both the column and the email of the condition for each email passed. This reduces it to a single IN check and a single usage of `upper` to do the case insensitive check. This tries to improve the performance of [this query](https://sentry.sentry.io/explore/traces/trace/9ec6750101a040ed9fcf09d0f3c3c911/?end=2025-05-29T16%3A27%3A49&fov=0%2C88401.99975585938&node=span-862c1dd548d34b56&node=txn-762dfb9f329f4a2d9fe18cdf374762ec&pageEnd=2025-05-29T16%3A27%3A49.000&pageStart=2025-05-29T16%3A25%3A13.000&project=-1&query=trace%3A9ec6750101a040ed9fcf09d0f3c3c911&source=traces&start=2025-05-29T16%3A25%3A13&targetId=bfbc97a674e16357×tamp=1748535996) (the trace might not point to the correct span, it is the `db` span) by reducing the repeated work of calling `UPPER` in so many conditions. Instead, I've updated the emails filter to annotate the queryset with the uppercased emails, then use the built in `__in` lookup against the emails in an uppercased format. This breaks us away from the `in_iexact` helper that was there before, but that helper is what generates the large condition and there is no clean way to do the lookup with `__in` in a case insensitive way that encapsulates the behaviour as cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve the performance of this filter. The current implementation creates an OR condition and calls upper on both the column and the email of the condition for each email passed. This reduces it to a single IN check and a single usage of
upperto do the case insensitive check.This tries to improve the performance of this query (the trace might not point to the correct span, it is the
dbspan) by reducing the repeated work of callingUPPERin so many conditions. Instead, I've updated the emails filter to annotate the queryset with the uppercased emails, then use the built in__inlookup against the emails in an uppercased format.This breaks us away from the
in_iexacthelper that was there before, but that helper is what generates the large condition and there is no clean way to do the lookup with__inin a case insensitive way that encapsulates the behaviour as cleanly.