Skip to content

fix(anomaly detection): handle anomaly detection edge case #92596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025

Conversation

natemoo-re
Copy link
Member

Follow-up to #91782. Moves the time window consistency check before making the request to Seer.

We should also follow-up with a fix to the underlying problem: async requests should be tracked against the time windows and we should be able to match historical and current datasets based on those time windows.

@natemoo-re natemoo-re requested a review from a team as a code owner May 30, 2025 22:02
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 30, 2025
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #92596       +/-   ##
===========================================
+ Coverage   45.20%   87.90%   +42.70%     
===========================================
  Files       10242    10251        +9     
  Lines      587433   587633      +200     
  Branches    22841    22793       -48     
===========================================
+ Hits       265531   516585   +251054     
+ Misses     321455    70602   -250853     
+ Partials      447      446        -1     

@natemoo-re natemoo-re enabled auto-merge (squash) June 3, 2025 16:55
@natemoo-re natemoo-re merged commit 5c0f684 into master Jun 3, 2025
43 checks passed
@natemoo-re natemoo-re deleted the anomaly-detection/nm/historical branch June 3, 2025 17:06
andrewshie-sentry pushed a commit that referenced this pull request Jun 3, 2025
Follow-up to #91782. Moves the time window consistency check before
making the request to Seer.

We should also follow-up with a fix to the underlying problem: async
requests should be tracked against the time windows and we should be
able to match historical and current datasets based on those time
windows.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants