-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(aci): Delete rows from GroupOpenPeriod #92687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
The code looks good, but can you please provide some more context around this, why is this being done? I see a PR opened before this one to backfill the data into this table. Are we going to delete all of the data, and then do the backfilling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to delete all of the data, and then do the backfilling?
@vgrozdanic - yeah that's the plan, the migration had some missing data so trying again.
PR lgtm from the product side.
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
@vgrozdanic we had a bug in the logic to write to this table hence the need to delete the rows. The data in GroupOpenPeriod isn't used anywhere yet, so the plan is to delete the rows, resume writes (feature-flagged), then backfill for existing groups |
Got it, thanks for clarifying! 🙏 |
Need to iterate over the rows because there's too many to simply `.all().delete()`
Need to iterate over the rows because there's too many to simply
.all().delete()