Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc): remove cdc stuff for real #6806

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

volokluev
Copy link
Member

spiritual successor to #6804

Copy link

codecov bot commented Jan 22, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12 1 11 0
View the top 1 failed tests by shortest run time
::tests.pipeline.test_entity_processing_stage_composite
Stack Traces | 0s run time
Traceback (most recent call last):
  File ".../datasets/entities/factory.py", line 50, in get
    return self._entity_map[name]
           ~~~~~~~~~~~~~~~~^^^^^^
KeyError: EntityKey.GROUPEDMESSAGE

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File ".../tests/pipeline/test_entity_processing_stage_composite.py", line 63, in <module>
    EntityKey.GROUPEDMESSAGE, get_entity(EntityKey.GROUPEDMESSAGE).get_data_model()
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../datasets/entities/factory.py", line 86, in get_entity
    return _ent_factory().get(name)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../datasets/entities/factory.py", line 52, in get
    raise InvalidEntityError(f"entity {name!r} does not exist") from error
snuba.datasets.entities.factory.InvalidEntityError: entity EntityKey.GROUPEDMESSAGE does not exist

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@volokluev volokluev force-pushed the volo/no_cdc_for_real branch from 5f40bec to 85648d0 Compare January 22, 2025 23:36
Copy link

This PR has a migration; here is the generated SQL for ./snuba/migrations/groups.py ()

-- start migrations

-- forward migration events : 0007_groupedmessages
-- end forward migration events : 0007_groupedmessages




-- backward migration events : 0007_groupedmessages
-- end backward migration events : 0007_groupedmessages
-- forward migration events : 0008_groupassignees
-- end forward migration events : 0008_groupassignees




-- backward migration events : 0008_groupassignees
-- end backward migration events : 0008_groupassignees
-- forward migration events : 0010_groupedmessages_onpremise_compatibility
-- end forward migration events : 0010_groupedmessages_onpremise_compatibility




-- backward migration events : 0010_groupedmessages_onpremise_compatibility
-- end backward migration events : 0010_groupedmessages_onpremise_compatibility

@volokluev volokluev marked this pull request as ready for review January 23, 2025 00:52
@volokluev volokluev requested review from a team as code owners January 23, 2025 00:52
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we haven't used this in issues for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants