Skip to content

build : start using a ggml submodule #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ggerganov opened this issue Feb 4, 2025 · 3 comments · May be fixed by #3001
Open

build : start using a ggml submodule #2785

ggerganov opened this issue Feb 4, 2025 · 3 comments · May be fixed by #3001
Labels
build Build related issues documentation Improvements or additions to documentation roadmap Part of a roadmap project

Comments

@ggerganov
Copy link
Member

Currently, the ggml source tree is synchronized into the source tree of whisper.cpp:

https://github.com/ggerganov/whisper.cpp/tree/master/ggml

This is not ideal, because the ggml source code is duplicated and has to be synchronized regularly via manual process. Instead, the ggml source should be available as a git submodule.

  • Reorganize this repo to start using ggml as a git submodule
  • Update documentation and build instructions
  • Add support for linking against external ggml binaries
@ggerganov ggerganov added build Build related issues documentation Improvements or additions to documentation roadmap Part of a roadmap project labels Feb 4, 2025
@mkmkme
Copy link

mkmkme commented Feb 4, 2025

Hey! I've never worked with whisper.cpp, but I find the project interesting. This task seems very easy, so if nobody takes it I can handle it later today.

@ggerganov
Copy link
Member Author

Thanks for the interest. Just to set the expectations correctly - none of the tasks in the new roadmap are really difficult from technical perspective, but they do require some level of commitment and familiarity with the project and it's intricacies. Such changes to the whisper.cpp build process would require good documentation, communication with developers and handling any issues that would arise from this change.

@WilliamTambellini
Copy link
Contributor

superb @ggerganov

danbev added a commit to danbev/whisper.cpp that referenced this issue Apr 3, 2025
@danbev
whisper : remove ggml source tree
6e142c3 
This commit removes the ggml source tree in favor of creating a git
submodule for https://github.com/ggml-org/ggml instead.

Refs: ggml-org#2785
@danbev danbev linked a pull request Apr 3, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Build related issues documentation Improvements or additions to documentation roadmap Part of a roadmap project
Projects
whisper.cpp : roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

whisper : add submodule for ggml danbev/whisper.cpp
3 participants
@WilliamTambellini @ggerganov @mkmkme