node : add language detection support #3190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add support for language detection in the Whisper Node.js
addon example.
The motivation for this is that currently there does not seem to be a
way to get the language detected by whisper.
Examples usage:
```console
$ node examples/addon.node/index.js --language='en' \
--model='models/ggml-base.bin' \
--fname_inp='samples/jfk.wav' \
--detect_language=true
whisperParams = {
language: 'en',
model: 'models/ggml-base.bin',
fname_inp: 'samples/jfk.wav',
use_gpu: true,
flash_attn: false,
no_prints: true,
comma_in_time: false,
translate: true,
no_timestamps: false,
detect_language: true,
audio_ctx: 0,
max_len: 0,
progress_callback: [Function: progress_callback]
}
{ language: 'en' }
```
Fix failing test.
This commit updates the node example to return an object instead of an
array as the results.
The motivation for this change is to enable the inclusion of the
detected language in the result, in addition to the transcription
segments.
For example, when using the `detect_language` option, the result will
now be:
```console
{ language: 'en' }
```
And if the `language` option is set to "auto", it will also return:
```console
{
language: 'en',
transcription: [
[
'00:00:00.000',
'00:00:07.600',
' And so my fellow Americans, ask not what your country can do for you,'
],
[
'00:00:07.600',
'00:00:10.600',
' ask what you can do for your country.'
]
]
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add support for language detection in the Whisper Node.js addon example.
The motivation for this is that currently there does not seem to be a way to get the language detected by whisper.
Examples usage:
And if the
languageoption is set to "auto":