Disable log and switch flash_attn to go binding. #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
reviewed
Jun 2, 2025
| @@ -99,9 +101,14 @@ var ( | |||
|
|
|||
| // Allocates all memory needed for the model and loads the model from the given file. | |||
| // Returns NULL on failure. | |||
| func Whisper_init(path string) *Context { | |||
| func Whisper_init(path string, flashAttn, disableLog bool) *Context { | |||
There was a problem hiding this comment.
I'm not sure about adding these context parameters like this. Perhaps instead there should be a method that takes ContextParams as an argument similar to the Java binding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disable_log to WHISPER_API, add disable_log and flash_attn switch to go binding