Skip to content

Commit 1bed097

Browse files
committed
Revert "make 1 heuristic per keyword list"
This reverts commit 7c2b76f.
1 parent 868f86e commit 1bed097

File tree

1 file changed

+25
-37
lines changed

1 file changed

+25
-37
lines changed

heuristics/bugginess.py

Lines changed: 25 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import re
2-
from typing import List, Optional
2+
from typing import Optional
33

44
import labels as l
55
from bohr.artifacts.commit import Commit
@@ -61,15 +61,13 @@
6161
"unsynchron",
6262
"wrong",
6363
],
64-
name_pattern="bug_message_keywords",
65-
lf_per_key_word=False,
64+
name_pattern="bug_message_keyword_%1",
6665
)
6766
def bug_keywords_lookup_in_message(
68-
commit: Commit, keywords: List[NgramSet]
67+
commit: Commit, keywords: NgramSet
6968
) -> Optional[Labels]:
70-
for keyword_group in keywords:
71-
if commit.message.match_ngrams(keyword_group):
72-
return l.CommitLabel.BugFix
69+
if commit.message.match_ngrams(keywords):
70+
return l.CommitLabel.BugFix
7371
return None
7472

7573

@@ -174,15 +172,13 @@ def bug_keywords_lookup_in_message(
174172
"upgrad",
175173
"version",
176174
],
177-
name_pattern="bugless_message_keywords",
178-
lf_per_key_word=False,
175+
name_pattern="bugless_message_keyword_%1",
179176
)
180177
def bugless_keywords_lookup_in_message(
181-
commit: Commit, keywords: List[NgramSet]
178+
commit: Commit, keywords: NgramSet
182179
) -> Optional[Labels]:
183-
for keyword_group in keywords:
184-
if commit.message.match_ngrams(keyword_group):
185-
return l.CommitLabel.NonBugFix
180+
if commit.message.match_ngrams(keywords):
181+
return l.CommitLabel.NonBugFix
186182
return None
187183

188184

@@ -213,30 +209,26 @@ def version_in_message(commit: Commit) -> Optional[Labels]:
213209
@KeywordHeuristics(
214210
Commit,
215211
keywords=["bug", "fixed", "fix", "error"],
216-
name_pattern="bug_issue_label_keywords",
217-
lf_per_key_word=False,
212+
name_pattern="bug_issue_label_keyword_%1",
218213
)
219214
def bug_keywords_lookup_in_issue_label(
220-
commit: Commit, keywords: List[NgramSet]
215+
commit: Commit, keywords: NgramSet
221216
) -> Optional[Labels]:
222-
for keyword_group in keywords:
223-
if commit.issues_match_label(keyword_group):
224-
return l.CommitLabel.BugFix
217+
if commit.issues_match_label(keywords):
218+
return l.CommitLabel.BugFix
225219
return None
226220

227221

228222
@KeywordHeuristics(
229223
Commit,
230224
keywords=["enhancement", "feature", "request", "refactor", "renovate", "new"],
231-
name_pattern="bugless_issue_label_keywords",
232-
lf_per_key_word=False,
225+
name_pattern="bugless_issue_label_keyword_%1",
233226
)
234227
def bugless_keywords_lookup_in_issue_label(
235-
commit: Commit, keywords: List[NgramSet]
228+
commit: Commit, keywords: NgramSet
236229
) -> Optional[Labels]:
237-
for keyword_group in keywords:
238-
if commit.issues_match_label(keyword_group):
239-
return l.CommitLabel.NonBugFix
230+
if commit.issues_match_label(keywords):
231+
return l.CommitLabel.NonBugFix
240232
return None
241233

242234

@@ -292,15 +284,13 @@ def bugless_keywords_lookup_in_issue_label(
292284
"unsynchron",
293285
"wrong",
294286
],
295-
name_pattern="bug_issue_body_keywords",
296-
lf_per_key_word=False,
287+
name_pattern="bug_issue_body_keyword_%1",
297288
)
298289
def bug_keywords_lookup_in_issue_body(
299-
commit: Commit, keywords: List[NgramSet]
290+
commit: Commit, keywords: NgramSet
300291
) -> Optional[Labels]:
301-
for keyword_group in keywords:
302-
if commit.issues_match_ngrams(keyword_group):
303-
return l.CommitLabel.BugFix
292+
if commit.issues_match_ngrams(keywords):
293+
return l.CommitLabel.BugFix
304294
return None
305295

306296

@@ -405,13 +395,11 @@ def bug_keywords_lookup_in_issue_body(
405395
"upgrad",
406396
"version",
407397
],
408-
name_pattern="bugless_issue_body_keywords",
409-
lf_per_key_word=False,
398+
name_pattern="bugless_issue_body_keyword_%1",
410399
)
411400
def bugless_keywords_lookup_in_issue_body(
412-
commit: Commit, keywords: List[NgramSet]
401+
commit: Commit, keywords: NgramSet
413402
) -> Optional[Labels]:
414-
for keyword_group in keywords:
415-
if commit.issues_match_ngrams(keyword_group):
416-
return l.CommitLabel.NonBugFix
403+
if commit.issues_match_ngrams(keywords):
404+
return l.CommitLabel.NonBugFix
417405
return None

0 commit comments

Comments
 (0)