[App] Github Login 추가 #325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redirect url을 잘 줘야 하더라
# Conflicts: # pnpm-lock.yaml
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
# Conflicts: # pnpm-lock.yaml
hyesungoh
approved these changes
May 1, 2025
Comment on lines
+13
to
+24
| useEffect(() => { | ||
| // 첫 렌더링에서는 리다이렉트 스킵 | ||
| if (isFirstRender.current) { | ||
| isFirstRender.current = false; | ||
| return; | ||
| } | ||
|
|
||
| // 이후 렌더링에서만 리다이렉트 수행 | ||
| if (!isAuthenticated) { | ||
| router.replace('/auth/login'); | ||
| } | ||
| }, [isAuthenticated]); |
Comment on lines
+26
to
+33
| const onPressLogout = async () => { | ||
| try { | ||
| await logout(); | ||
| router.replace('/auth/login'); | ||
| } catch (error) { | ||
| console.error('로그아웃 실패:', error); | ||
| } | ||
| }; |
There was a problem hiding this comment.
이러면 사용자는 로그아웃 버튼을 눌러도 아무런 변화를 느낄 수 없지 않을까염??
Comment on lines
+62
to
+75
| const styles = StyleSheet.create({ | ||
| container: { | ||
| flex: 1, | ||
| backgroundColor: '#fff', | ||
| }, | ||
| safeArea: { | ||
| backgroundColor: '#f8f9fa', | ||
| }, | ||
| header: { | ||
| backgroundColor: '#f8f9fa', | ||
| borderBottomWidth: 1, | ||
| borderBottomColor: '#e9ecef', | ||
| ...Platform.select({ | ||
| ios: { |
There was a problem hiding this comment.
각각 다른 변수로 뺄 수 있을 거 같은데, 하나의 객체로 만드신 이유가 궁금해용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 기능
🔎 기타