Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Max Score, Setup CI Job + File Cleanup #2

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Conversation

ashishkeshan
Copy link

@ashishkeshan ashishkeshan commented Feb 29, 2024

Changes related to scoring system:

  • runner/data.py: Added a max_score attribute to the Results class, which will hold the maximum possible score for the tests.
  • runner/__init__.py: Modified the run function to accept max_score as a parameter and set it as the max_score of the Results object. [1] [2]
  • runner/__init__.py: Updated the pytest_sessionfinish method to calculate the score for each test based on whether it's passing and the number of tests.

Also added an integration test and removed unneeded action files.

@ashishkeshan ashishkeshan changed the title add max score Add Max Score, Setup CI Job + File Cleanup Mar 5, 2024
@ashishkeshan ashishkeshan marked this pull request as ready for review March 5, 2024 17:51
Copy link

@Saturn226 Saturn226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ashishkeshan ashishkeshan merged commit d784da5 into main Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants