[GHSA-572q-86rr-5vgq] Umbraco Rich Text Display allows Cross-Site Scripting #5270
+5
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
I head up the CMS team at Umbraco and have responsibility for the product in question.
I've suggested some updates here but my first request would actually be for you to consider to please remove this. This is for a few reasons:
The issue raised is already documented with a solution (https://docs.umbraco.com/umbraco-cms/reference/security/serverside-sanitizing). To summarise, the potential attack is only possible via authenticated users, who have been manually allowed access to the CMS, providing content for presentation on the website. We have taken a deliberate decision to not apply HTML sanitization at the product level, potentially changing user's content in ways they don't expect. Rather we provide a hook so a customer can use their own preferred library or website to do this. Most customers do not feel this is necessary for their setup but for those that do, they have the option to implement it.
The raising of the issue didn't follow our documented security policy: https://umbraco.com/trust-center/security-and-umbraco/how-to-report-a-vulnerability-in-umbraco/. Rather the details were simply published to a blog rather than reaching out to us: https://www.nccgroup.com/us/research-blog/technical-advisory-cross-site-scripting-in-umbraco-rich-text-display/
The write-up claims a response from Umbraco, but references a single comment from someone external to the Umbraco organisation responding on a public forum: Adding a Warning Label to the Rich Text Editor umbraco/Umbraco-CMS#17658
The write-up you reference contains several inaccuracies and links to irrelevant code updates, so is causing confusion for our users.
In terms of the updates I've made if you do feel this needs to remain in your database:
Thanks very much for your help with this matter.