Michaelrfairhurst/address rule amendments from amd3

[MichaelRFairhurst]

Description

Address most MISRA C 2012 rule amendments in Amendment3.

Does not address amendments that are covered in other PRs (clarifications) or
Generics behavior. Most updates related to complex floating types. One update
related to emergent language features.

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql, .qll, .qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • rule number here
• Queries have been modified for the following rules:
  • DIR-4-6
  • RULE-10-1
  • RULE-10-3
  • RULE-10-4
  • RULE-10-5
  • RULE-10-7
  • RULE-10-8
  • RULE-14-1

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

• Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

• Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Reviewer

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Copilot reviewed 9 out of 29 changed files in this pull request and generated no comments.

Files not reviewed (20)

• amendments.csv: Language not supported
• c/misra/src/codingstandards/c/misra/EssentialTypes.qll: Language not supported
• c/misra/src/rules/DIR-4-6/PlainNumericalTypeUsedOverExplicitTypedef.ql: Language not supported
• c/misra/src/rules/RULE-10-1/OperandsOfAnInappropriateEssentialType.ql: Language not supported
• c/misra/src/rules/RULE-10-3/AssignmentOfIncompatibleEssentialType.ql: Language not supported
• c/misra/src/rules/RULE-10-4/OperandsWithMismatchedEssentialTypeCategory.ql: Language not supported
• c/misra/src/rules/RULE-10-5/InappropriateEssentialTypeCast.ql: Language not supported
• c/misra/src/rules/RULE-10-7/ImplicitConversionOfCompositeExpression.ql: Language not supported
• c/misra/src/rules/RULE-10-8/InappropriateCastOfCompositeExpression.ql: Language not supported
• c/misra/src/rules/RULE-14-1/LoopOverEssentiallyFloatType.ql: Language not supported
• c/misra/test/rules/DIR-4-6/PlainNumericalTypeUsedOverExplicitTypedef.expected: Language not supported
• c/misra/test/rules/DIR-4-6/test.c: Language not supported
• c/misra/test/rules/RULE-1-4/EmergentLanguageFeaturesUsed.expected: Language not supported
• c/misra/test/rules/RULE-1-4/test.c: Language not supported
• c/misra/test/rules/RULE-10-1/OperandsOfAnInappropriateEssentialType.expected: Language not supported
• c/misra/test/rules/RULE-10-1/PointerTypeOnLogicalOperator.expected: Language not supported
• c/misra/test/rules/RULE-10-1/test.c: Language not supported
• c/misra/test/rules/RULE-10-3/AssignmentOfIncompatibleEssentialType.expected: Language not supported
• c/misra/test/rules/RULE-10-3/test.c: Language not supported
• c/misra/test/rules/RULE-10-4/OperandsWithMismatchedEssentialTypeCategory.expected: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

[lcartey]

A couple of comments on the changes to emergent language features.

[lcartey]

Did you mean to make these changes here?

[MichaelRFairhurst]

I did mean to, yes. This covers all the amendments that aren't blocked from amoundment3.

However, I reverted the deletion of _Generic, and I changed amendments.csv to mark the RULE-1-4 as not yet implemented, so that we don't forget to revisit that once generics are landed.

[MichaelRFairhurst]

Also reverted deletions of atomics, threads, since those rules haven't been merged yet, and marked RULE-1-4 from amendment 4 not yet implemented.