Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions to codeql analysis workflow #18742

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −2
Open

Add actions to codeql analysis workflow #18742

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bd116f
Add actions to codeql analysis workflow
oscarsj Feb 11, 2025
3611673
Fix param name in CodeQL workflow configuration
oscarsj Feb 12, 2025
efd9523
Fix typo in CodeQL workflow configuration
oscarsj Feb 12, 2025
98ff406
Add codeql exception to integration-tests folder
oscarsj Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ on:

jobs:
CodeQL-Build:
strategy:
fail-fast: false
matrix:
language: ['actions', 'csharp']

runs-on: ubuntu-latest

Expand All @@ -38,9 +42,7 @@ jobs:
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@main
# Override language selection by uncommenting this and choosing your languages
with:
languages: csharp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have worked (in fact it is attempting all languages). I suspect the docs or our automatic parsing of workflow matrices are wrong. Can you try an explicit languages: ${{ matrix.language }} here?

We may also need to specify a category so that the old and new csharp alerts match up.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand this correctly in that matrix.<dimension> would get passed to an action implicitly if it has an input of the same name? In that case the problem is likely language vs languages. I would prefer to pass it explicitly (languages: ${{ matrix.language }}) for clarity , though.

config-file: ./.github/codeql/codeql-config.yml

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
Expand Down
Loading