Fix tabindex='-1' elements being tabbable

muan · muan · commit 6866b962dbba · 2019-04-02T18:02:36.000-04:00
diff --git a/index.js b/index.js
@@ -33,8 +33,7 @@ function keydown(event: KeyboardEvent): void {
 
 function focusable(el: Focusable): boolean {
   return (
-    (el.hasAttribute('tabindex') || el.tabIndex >= 0) &&
-    (!el.disabled && !el.hidden && (!el.type || el.type !== 'hidden') && !el.closest('[hidden]'))
+    el.tabIndex >= 0 && (!el.disabled && !el.hidden && (!el.type || el.type !== 'hidden') && !el.closest('[hidden]'))
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,7 @@ function keydown(event: KeyboardEvent): void {`
`33`	`33`
`34`	`34`	`function focusable(el: Focusable): boolean {`
`35`	`35`	`return (`
`36`		`- (el.hasAttribute('tabindex') \|\| el.tabIndex >= 0) &&`
`37`		`- (!el.disabled && !el.hidden && (!el.type \|\| el.type !== 'hidden') && !el.closest('[hidden]'))`
	`36`	`+ el.tabIndex >= 0 && (!el.disabled && !el.hidden && (!el.type \|\| el.type !== 'hidden') && !el.closest('[hidden]'))`
`38`	`37`	`)`
`39`	`38`	`}`
`40`	`39`