Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause Follow and Unfollow endpoints #324

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sarwaan001
Copy link

@sarwaan001 sarwaan001 commented Feb 12, 2025

  • Pause follow endpoint for ccr
  • Unfollow Endpoint for ccr

@sarwaan001 sarwaan001 marked this pull request as ready for review February 13, 2025 10:26
@Copilot Copilot bot review requested due to automatic review settings February 13, 2025 10:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request introduces new functionality to pause the follow process for CCR as well as updates the existing unfollow endpoint in the ElastomerClient. Key changes include:

  • Adding a new pause_follow method with documentation and a corresponding API call
  • Updating the unfollow method documentation to clarify usage and pre-conditions
  • Enhancing test coverage by adding helper methods and tests for follow, pause_follow, and unfollow endpoints
  • Switching test hook syntax from the default to before/after :each blocks for consistency

Changes

File Description
lib/elastomer_client/client/ccr.rb Added pause_follow endpoint; updated unfollow docs
test/client/ccr_test.rb Added tests for pause_follow and unfollow endpoints

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

lib/elastomer_client/client/ccr.rb:42

  • [nitpick] The comment for 'follower_index' could be reworded to clarify the intent, e.g., 'follower_index - String name of the follower index to pause'.
# follower_index - String name of the follower index pause

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

# Unfollows a leader index given a follower index.
# The follower index must be paused and closed before unfollowing.
#
# follower_index - String name of the follower index to create
Copy link
Preview

Copilot AI Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment inaccurately states 'to create'; consider revising it to 'follower_index - String name of the follower index to unfollow'.

Suggested change
# follower_index - String name of the follower index to create
# follower_index - String name of the follower index to unfollow

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@sarwaan001 sarwaan001 changed the title Feature: Pause Follow Endpoint Pause Follow and Unfollow endpoints Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant