Add auto Follow #325
Add auto Follow #325
Conversation
There was a problem hiding this comment.
PR Overview
This pull request adds support for auto-follow policies in cross-cluster replication. The changes include new test setups and verifications to ensure an auto-follow policy is correctly created, retrieved, and cleaned up, as well as new methods in the client for creating, deleting, and retrieving auto-follow patterns.
- Updated tests to set up and validate auto-follow indices.
- Added new methods in the client to interact with auto-follow patterns.
- Updated cleanup logic in tests to remove auto-follow patterns after test execution.
Changes
| File | Description |
|---|---|
| test/client/ccr_test.rb | Added tests for auto-follow policy, creating new indexes and cleanup logic |
| lib/elastomer_client/client/ccr.rb | Implemented API support for creating, deleting, and retrieving auto-follow patterns |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
| # See https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-put-auto-follow-pattern.html | ||
|
|
||
| def auto_follow(pattern_name, body, params = {}) | ||
| response = client.put "/_ccr/auto_follow/#{pattern_name}", params.merge(params, body:, action: "create_auto_follow_pattern", rest_api: "ccr") |
There was a problem hiding this comment.
The auto_follow method calls merge on params twice, which may lead to unexpected duplication of parameters. Consider using a single merge combining the body and params, for example: params.merge(body: body, action: "create_auto_follow_pattern", rest_api: "ccr").
| response = client.put "/_ccr/auto_follow/#{pattern_name}", params.merge(params, body:, action: "create_auto_follow_pattern", rest_api: "ccr") | |
| response = client.put "/_ccr/auto_follow/#{pattern_name}", params.merge(body: body, action: "create_auto_follow_pattern", rest_api: "ccr") |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
No description provided.