Use gitoxide for get_tags
#2664
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruessler
force-pushed
the
use-gitoxide-for-tags
branch
from
8604295 to
49cd6a7
Compare
Byron
reviewed
Jun 9, 2025
Byron
reviewed
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft, currently intended for a discussion with @Byron about the part of the API to be used for getting a reference’s name. I intend to mark it as ready once I’ve figured out how to best use the existing APIs.
Update 2025-06-09: this PR is now ready for review.
This PR changes the following:
get_tagsto usegitoxideunder the hood.gitoxideversion properly show an@symbol in the tags popup for annotated tags, something thelibgitversion doesn’t do. (I didn’t investigate this in depth, though.)I followed the checklist:
make checkwithout errors