Skip to content
This repository was archived by the owner on Jan 18, 2021. It is now read-only.

There should be a hook exposing jsTree to addons #151

Open
rondale-sc opened this issue Oct 30, 2018 · 0 comments
Open

There should be a hook exposing jsTree to addons #151

rondale-sc opened this issue Oct 30, 2018 · 0 comments

Comments

@rondale-sc
Copy link
Contributor

In glimmer-app.ts there are a few addonProcessTree calls that expose things like:

  • postprocessTree
  • preprocessTree

For the src and css trees. However, since the jsTree is from the result of the src tree going through the TS compiler inside the javascriptTree function (see: https://github.com/glimmerjs/glimmer-application-pipeline/blob/master/lib/broccoli/glimmer-app.ts#L407) there is no opportunity to inject non typescript modules into the JS output.

This was made apparent to me when I tried to create a module that was in the jsTree before rollup happened in the package method. I was forced to modify the srcTree and add a TS file there which was inconvenient. I think on L407 (linked above) we should add a addonProcessTree to expose the javascriptTree to user space.

Any thoughts on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant