You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 18, 2021. It is now read-only.
This was made apparent to me when I tried to create a module that was in the jsTree before rollup happened in the package method. I was forced to modify the srcTree and add a TS file there which was inconvenient. I think on L407 (linked above) we should add a addonProcessTree to expose the javascriptTree to user space.
Any thoughts on this?
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In glimmer-app.ts there are a few addonProcessTree calls that expose things like:
postprocessTree
preprocessTree
For the
src
andcss
trees. However, since the jsTree is from the result of the src tree going through the TS compiler inside thejavascriptTree
function (see: https://github.com/glimmerjs/glimmer-application-pipeline/blob/master/lib/broccoli/glimmer-app.ts#L407) there is no opportunity to inject non typescript modules into the JS output.This was made apparent to me when I tried to create a module that was in the jsTree before rollup happened in the package method. I was forced to modify the
srcTree
and add a TS file there which was inconvenient. I think on L407 (linked above) we should add aaddonProcessTree
to expose thejavascriptTree
to user space.Any thoughts on this?
The text was updated successfully, but these errors were encountered: