factoryFor injections
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @robbiepitts! This LGTM. I think that tracking |
pittst3r
force-pushed
the
factory-for-injections
branch
from
92ded37 to
f3797f7
Compare
dgeb
reviewed
Feb 28, 2017
src/container.ts
Outdated
| } | ||
|
|
||
| factoryFor(specifier: string): Factory<any> { | ||
| let factory = this._factoryLookups[specifier]; | ||
| let creator: FactoryDefinition<any> = this._creatorLookups[specifier]; |
There was a problem hiding this comment.
s/creator/factoryDefinition/
or simply
s/creator/definition/
pittst3r
force-pushed
the
factory-for-injections
branch
from
f3797f7 to
139beed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
factoryForinterface specified in https://github.com/emberjs/rfcs/blob/master/text/0150-factory-for.md and introduces concept ofCreator(which is distinct fromFactory). One registers Creators and retrieves Factories.