Remove invalid callee nodes from AST v2

`{{("foo")}}` etc is illegal and already covered by existing tests.

Currently this is checked by the parser (handlebars-node-visitors)
but AST plugins can violate this constraint in theory.

Author: chancancode

packages/@glimmer/compiler/lib/passes/1-normalization/keywords/impl.ts

@@ -78,12 +78,6 @@ class KeywordImpl<
   }
 }
 
-export type PossibleNode =
-  | ASTv2.PathExpression
-  | ASTv2.AppendContent
-  | ASTv2.CallExpression
-  | ASTv2.InvokeBlock;
-
 export const KEYWORD_NODES = {
   Call: ['Call'],
   Block: ['InvokeBlock'],

packages/@glimmer/syntax/lib/v1/nodes-v1.ts

@@ -43,6 +43,7 @@ export interface CallParts {
   path: CallableExpression;
   params: Expression[];
   hash: Hash;
+  loc: src.SourceSpan;
 }
 
 export type CallNode =

packages/@glimmer/syntax/lib/v2/builders.ts

@@ -9,7 +9,7 @@ import { SpanList } from '../source/span-list';
 import * as ASTv2 from './api';
 
 export interface CallParts {
-  callee: ASTv2.ExpressionNode;
+  callee: ASTv2.CalleeNode;
   args: ASTv2.Args;
 }
 

packages/@glimmer/syntax/lib/v2/normalize.ts

@@ -243,7 +243,7 @@ class ExpressionNormalizer {
    * it to an ASTv2 CallParts.
    */
   callParts(parts: ASTv1.CallParts, context: ASTv2.FreeVarResolution): CallParts {
-    let { path, params, hash } = parts;
+    let { path, params, hash, loc } = parts;
 
     let callee = this.normalize(path, context);
     let paramList = params.map((p) => this.normalize(p, ASTv2.STRICT_RESOLUTION));
@@ -261,6 +261,21 @@ class ExpressionNormalizer {
       this.block.loc(hash.loc)
     );
 
+    switch (callee.type) {
+      case 'Literal':
+        throw generateSyntaxError(
+          `Invalid invocation of a literal value (\`${callee.value}\`)`,
+          loc
+        );
+
+      // This really shouldn't be possible, something has gone pretty wrong
+      case 'Interpolate':
+        throw generateSyntaxError(
+          `Invalid invocation of a interpolated string`,
+          loc
+        );
+    }
+
     return {
       callee,
       args: this.block.builder.args(positional, named, argsLoc),
@@ -402,6 +417,7 @@ class StatementNormalizer {
           path,
           params,
           hash,
+          loc,
         },
         resolution.result
       );

packages/@glimmer/syntax/lib/v2/objects/base.ts

@@ -2,7 +2,7 @@ import type { SerializedSourceSpan } from '../../source/span';
 import type { Args } from './args';
 import type { ElementModifier } from './attr-block';
 import type { AppendContent, ContentNode, InvokeBlock, InvokeComponent } from './content';
-import type { CallExpression, ExpressionNode } from './expr';
+import type { CallExpression, PathExpression } from './expr';
 import type { BaseNodeFields } from './node';
 
 export interface SerializedBaseNode {
@@ -14,10 +14,14 @@ export interface GlimmerParentNodeOptions extends BaseNodeFields {
 }
 
 export interface CallFields extends BaseNodeFields {
-  callee: ExpressionNode;
+  callee: CalleeNode;
   args: Args;
 }
 
+export type CalleeNode =
+| PathExpression
+| CallExpression;
+
 export type CallNode =
   | CallExpression
   | InvokeBlock