Merge pull request #1720 from glimmerjs/printer-quote-bug

Printer quoting bug

Author: ef4

packages/@glimmer/syntax/lib/generation/printer.ts

@@ -293,22 +293,32 @@ export default class Printer {
 
   AttrNodeValue(value: ASTv1.AttrNode['value']): void {
     if (value.type === 'TextNode') {
-      this.buffer += '"';
-      this.TextNode(value, true);
-      this.buffer += '"';
+      let quote: '"' | "'" = '"';
+      if (this.options.entityEncoding === 'raw') {
+        if (value.chars.includes('"') && !value.chars.includes("'")) {
+          quote = "'";
+        }
+      }
+      this.buffer += quote;
+      this.TextNode(value, quote);
+      this.buffer += quote;
     } else {
       this.Node(value);
     }
   }
 
-  TextNode(text: ASTv1.TextNode, isAttr?: boolean): void {
+  TextNode(text: ASTv1.TextNode, isInAttr?: "'" | '"'): void {
     if (this.handledByOverride(text)) {
       return;
     }
 
     if (this.options.entityEncoding === 'raw') {
-      this.buffer += text.chars;
-    } else if (isAttr) {
+      if (isInAttr && text.chars.includes(isInAttr)) {
+        this.buffer += escapeAttrValue(text.chars);
+      } else {
+        this.buffer += text.chars;
+      }
+    } else if (isInAttr) {
       this.buffer += escapeAttrValue(text.chars);
     } else {
       this.buffer += escapeText(text.chars);
@@ -393,7 +403,7 @@ export default class Printer {
     this.buffer += '"';
     concat.parts.forEach((part) => {
       if (part.type === 'TextNode') {
-        this.TextNode(part, true);
+        this.TextNode(part, '"');
       } else {
         this.Node(part);
       }

packages/@glimmer/syntax/test/generation/print-test.ts

@@ -152,7 +152,38 @@ QUnit.module('[glimmer-syntax] Code generation - source -> source', () => {
     ' {{#foo}}\n  {{bar}}\n {{/foo}}',
 
     `<span class="stampFont" style="font-family: 'stampfont'">&#xf000;</span>`,
+
+    // preserves single quoting when it avoids introducing &quot;
+    `<div class='He said "yes"'></div>`,
   ].forEach(buildTest);
+
+  test('falls back to using entity encoding when necessary for correctness', (assert) => {
+    let ast = parse(`<div class='transform-target'></div>`, {
+      mode: 'codemod',
+      parseOptions: { ignoreStandalone: true },
+      plugins: {
+        ast: [
+          function (_env) {
+            return {
+              name: 'test',
+              visitor: {
+                TextNode(x) {
+                  if (x.chars === 'transform-target') {
+                    x.chars = 'He said "can\'t"';
+                  }
+                },
+              },
+            };
+          },
+        ],
+      },
+    });
+
+    assert.strictEqual(
+      print(ast, { entityEncoding: 'raw' }),
+      `<div class="He said &quot;can't&quot;"></div>`
+    );
+  });
 });
 
 QUnit.module('[glimmer-syntax] Code generation - override', () => {