Improve forbidden texts

1. Allow forbidden texts to be regexes
2. Update `check(` so require a function-like calling syntax
3. Remove `@glimmer/syntax` from `IGNORED_DIRS` by avoiding using
   `check` as an internal method.

Author: wycats

bin/build-verify.mjs

@@ -16,14 +16,14 @@ const FORBIDDEN = [
   /**
    * These are for local VM debugging and development, and are not meant to make it to real code
    */
-  'check(',
+  /[^.]check\(/,
   'CheckInterface',
   'CheckOr',
   'CheckFunction',
   'CheckObject',
 ];
 
-const IGNORED_DIRS = [`@glimmer/syntax`, `@glimmer/debug`];
+const IGNORED_DIRS = [`@glimmer/debug`];
 
 let files = await globby(resolve(currentDir, '../../packages/**/dist/**/index.js'), {
   ignore: ['node_modules', '**/node_modules'],
@@ -41,7 +41,7 @@ for (let filePath of files) {
   let content = file.toString();
 
   for (let searchFor of FORBIDDEN) {
-    if (content.includes(searchFor)) {
+    if (content.match(searchFor)) {
       errors.push({ filePath, found: searchFor });
     }
   }

packages/@glimmer/syntax/lib/source/loc/match.ts

@@ -99,11 +99,11 @@ type ExhaustiveCheck<Out, In extends Matches, Removed extends Matches> = Exclude
 export type MatchFn<Out> = (left: PositionData, right: PositionData) => Out;
 
 interface ExhaustiveMatcher<Out> {
-  check(): MatchFn<Out>;
+  validate(): MatchFn<Out>;
 }
 
 export function match<Out>(callback: (m: Matcher<Out>) => ExhaustiveMatcher<Out>): MatchFn<Out> {
-  return callback(new Matcher()).check();
+  return callback(new Matcher()).validate();
 }
 
 class Matcher<Out, M extends Matches = Matches> {
@@ -112,7 +112,7 @@ class Matcher<Out, M extends Matches = Matches> {
   /**
    * You didn't exhaustively match all possibilities.
    */
-  protected check(): MatchFn<Out> {
+  protected validate(): MatchFn<Out> {
     return (left, right) => this.matchFor(left.kind, right.kind)(left, right);
   }
 

packages/@glimmer/syntax/lib/source/loc/offset.ts

@@ -104,7 +104,7 @@ export class SourceOffset {
     } else {
       const result = charPos.offset + by;
 
-      if (charPos.source.check(result)) {
+      if (charPos.source.validate(result)) {
         return new CharPosition(charPos.source, result).wrap();
       } else {
         return SourceOffset.broken();

packages/@glimmer/syntax/lib/source/source.ts

@@ -19,7 +19,7 @@ export class Source {
   /**
    * Validate that the character offset represents a position in the source string.
    */
-  check(offset: number): boolean {
+  validate(offset: number): boolean {
     return offset >= 0 && offset <= this.source.length;
   }