Skip to content

Commit 6aeb1b2

Browse files
committedFeb 24, 2024
Drop the defunct PartialStatementNode from v1 AST
Note that this is referring to the Handlebars `{{> ... }}` syntax, not the (also defunct) Ember `{{partial ...}}` feature. This had never worked in any modern versions of Ember (maybe v1+) and the compiler doesn't do anything with it.
1 parent eee6eea commit 6aeb1b2

File tree

5 files changed

+0
-48
lines changed

5 files changed

+0
-48
lines changed
 

‎packages/@glimmer/syntax/lib/generation/printer.ts

-15
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ export default class Printer {
9696
switch (node.type) {
9797
case 'MustacheStatement':
9898
case 'BlockStatement':
99-
case 'PartialStatement':
10099
case 'MustacheCommentStatement':
101100
case 'CommentStatement':
102101
case 'TextNode':
@@ -161,8 +160,6 @@ export default class Printer {
161160
return this.MustacheStatement(statement);
162161
case 'BlockStatement':
163162
return this.BlockStatement(statement);
164-
case 'PartialStatement':
165-
return this.PartialStatement(statement);
166163
case 'MustacheCommentStatement':
167164
return this.MustacheCommentStatement(statement);
168165
case 'CommentStatement':
@@ -388,18 +385,6 @@ export default class Printer {
388385
this.buffer += ` as |${blockParams.join(' ')}|`;
389386
}
390387

391-
PartialStatement(partial: ASTv1.PartialStatement): void {
392-
if (this.handledByOverride(partial)) {
393-
return;
394-
}
395-
396-
this.buffer += '{{>';
397-
this.Expression(partial.name);
398-
this.Params(partial.params);
399-
this.Hash(partial.hash);
400-
this.buffer += '}}';
401-
}
402-
403388
ConcatStatement(concat: ASTv1.ConcatStatement): void {
404389
if (this.handledByOverride(concat)) {
405390
return;

‎packages/@glimmer/syntax/lib/v1/nodes-v1.ts

-11
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,6 @@ export interface ElementModifierStatement extends BaseNode {
9393
hash: Hash;
9494
}
9595

96-
export interface PartialStatement extends BaseNode {
97-
type: 'PartialStatement';
98-
name: PathExpression | SubExpression;
99-
params: Expression[];
100-
hash: Hash;
101-
indent: string;
102-
strip: StripFlags;
103-
}
104-
10596
export interface CommentStatement extends BaseNode {
10697
type: 'CommentStatement';
10798
value: string;
@@ -167,7 +158,6 @@ export type StatementName =
167158
| 'MustacheStatement'
168159
| 'CommentStatement'
169160
| 'BlockStatement'
170-
| 'PartialStatement'
171161
| 'MustacheCommentStatement'
172162
| 'TextNode'
173163
| 'ElementNode';
@@ -318,7 +308,6 @@ export type SharedNodes = {
318308
UndefinedLiteral: UndefinedLiteral;
319309
MustacheStatement: MustacheStatement;
320310
ElementModifierStatement: ElementModifierStatement;
321-
PartialStatement: PartialStatement;
322311
AttrNode: AttrNode;
323312
ConcatStatement: ConcatStatement;
324313
};

‎packages/@glimmer/syntax/lib/v1/public-builders.ts

-19
Original file line numberDiff line numberDiff line change
@@ -105,24 +105,6 @@ function buildElementModifier(
105105
};
106106
}
107107

108-
function buildPartial(
109-
name: ASTv1.PathExpression,
110-
params?: ASTv1.Expression[],
111-
hash?: ASTv1.Hash,
112-
indent?: string,
113-
loc?: SourceLocation
114-
): ASTv1.PartialStatement {
115-
return {
116-
type: 'PartialStatement',
117-
name: name,
118-
params: params || [],
119-
hash: hash || buildHash([]),
120-
indent: indent || '',
121-
strip: { open: false, close: false },
122-
loc: buildLoc(loc || null),
123-
};
124-
}
125-
126108
function buildComment(value: string, loc?: SourceLocation): ASTv1.CommentStatement {
127109
return {
128110
type: 'CommentStatement',
@@ -512,7 +494,6 @@ function buildLoc(...args: any[]): SourceSpan {
512494
export default {
513495
mustache: buildMustache,
514496
block: buildBlock,
515-
partial: buildPartial,
516497
comment: buildComment,
517498
mustacheComment: buildMustacheComment,
518499
element: buildElement,

‎packages/@glimmer/syntax/lib/v1/visitor-keys.ts

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const visitorKeys = {
99
MustacheStatement: ['path', 'params', 'hash'],
1010
BlockStatement: ['path', 'params', 'hash', 'program', 'inverse'],
1111
ElementModifierStatement: ['path', 'params', 'hash'],
12-
PartialStatement: ['name', 'params', 'hash'],
1312
CommentStatement: [],
1413
MustacheCommentStatement: [],
1514
ElementNode: ['attributes', 'modifiers', 'children', 'comments'],

‎packages/@glimmer/syntax/lib/v2/normalize.ts

-2
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,6 @@ class StatementNormalizer {
323323

324324
normalize(node: ASTv1.Statement): ASTv2.ContentNode | ASTv2.NamedBlock {
325325
switch (node.type) {
326-
case 'PartialStatement':
327-
throw new Error(`Handlebars partial syntax ({{> ...}}) is not allowed in Glimmer`);
328326
case 'BlockStatement':
329327
return this.BlockStatement(node);
330328
case 'ElementNode':

0 commit comments

Comments
 (0)
Failed to load comments.