fix

Author: patricklx

packages/@glimmer/validator/lib/tracked-utils.ts

@@ -1,23 +1,23 @@
-import type { Tag } from "@glimmer/interfaces";
+import type { Tag } from '@glimmer/interfaces';
 
-import type { MonomorphicTagImpl } from "./validators";
+import type { MonomorphicTagImpl } from './validators';
 
-import { infoForTag, tagFor} from "./meta";
-import { track } from "./tracking";
-import { validateTag, valueForTag } from "./validators";
+import { infoForTag, tagFor } from './meta';
+import { track } from './tracking';
+import { validateTag, valueForTag } from './validators';
 
 type Info = {
   tag: MonomorphicTagImpl;
   latestValue: number;
   dependencies: {
-    object: object,
+    object: object;
     propertyKey: string;
     changed: boolean;
   }[];
-}
+};
 
 export function getTrackedDependencies(obj: Record<string, any>, property: string, info?: Info) {
-  info = info || {} as Info;
+  info = info || ({} as Info);
   const tag = info?.tag || track(() => obj[property]);
   const dependencies = [];
   // do not include tracked properties from dependencies
@@ -36,11 +36,12 @@ export function getTrackedDependencies(obj: Record<string, any>, property: strin
   let maxRevision = info?.latestValue || valueForTag(tag);
   let minRevision = Infinity;
   dependencies.forEach((t) => {
-    maxRevision = Math.max(maxRevision, valueForTag(t.tag));
-    minRevision = Math.min(minRevision, valueForTag(t.tag));
+    const value = valueForTag(t.tag);
+    maxRevision = Math.max(maxRevision, value);
+    minRevision = Math.min(minRevision, value);
   });
 
-  const hasChange = info.latestValue && (maxRevision !== info.latestValue) || false;
+  const hasChange = (info.latestValue && maxRevision !== info.latestValue) || false;
   let latestValue = valueForTag(tag);
 
   info.latestValue = latestValue;
@@ -61,19 +62,19 @@ type TrackedInfo = {
 };
 
 export function getChangedProperties(obj: object, trackedInfo?: TrackedInfo) {
-  trackedInfo = trackedInfo || {} as TrackedInfo;
+  trackedInfo = trackedInfo || ({} as TrackedInfo);
   trackedInfo['changed'] = [];
   trackedInfo.propertyInfo = trackedInfo.propertyInfo || {};
   for (const name in obj) {
     let tagInfo = trackedInfo.propertyInfo?.[name] || {
       tag: tagFor(obj, name),
-      revision: (tagFor(obj, name)  as MonomorphicTagImpl)['revision'],
+      revision: (tagFor(obj, name) as MonomorphicTagImpl)['revision'],
     };
     if (!tagInfo.tag) return;
     trackedInfo.propertyInfo[name] = tagInfo;
 
     const changed = !validateTag(tagInfo.tag, tagInfo.revision);
-    tagInfo.revision = (tagInfo.tag as MonomorphicTagImpl)["revision"]
+    tagInfo.revision = (tagInfo.tag as MonomorphicTagImpl)['revision'];
     if (changed) {
       trackedInfo['changed'].push(name);
     }

packages/@glimmer/validator/test/meta-test.ts

@@ -1,10 +1,4 @@
-import {
-  dirtyTagFor,
-  infoForTag,
-  tagFor,
-  validateTag,
-  valueForTag,
-} from '@glimmer/validator';
+import { dirtyTagFor, infoForTag, tagFor, validateTag, valueForTag } from '@glimmer/validator';
 
 import { module, test } from './-utils';
 

packages/@glimmer/validator/test/tracked-utils-test.ts

@@ -1,11 +1,8 @@
-import {
-  getChangedProperties, getTrackedDependencies, trackedData
-} from '@glimmer/validator';
+import { getChangedProperties, getTrackedDependencies, trackedData } from '@glimmer/validator';
 
 import { module, test } from './-utils';
 
 module('@glimmer/validator: tracked-utils', () => {
-
   class TestObject {
     declare item1: string;
     declare item2: string;
@@ -70,7 +67,7 @@ module('@glimmer/validator: tracked-utils', () => {
         changed: false,
         object: obj,
         propertyKey: 'item2',
-      }
+      },
     ]);
 
     obj.item1 = 'hi';
@@ -84,7 +81,7 @@ module('@glimmer/validator: tracked-utils', () => {
         changed: false,
         object: obj,
         propertyKey: 'item2',
-      }
+      },
     ]);
     assert.deepEqual(getTrackedDependencies(obj, 'getterWithTracked', info).dependencies, [
       {
@@ -96,7 +93,7 @@ module('@glimmer/validator: tracked-utils', () => {
         changed: false,
         object: obj,
         propertyKey: 'item2',
-      }
+      },
     ]);
   });
 });