Skip to content

Commit ad7f15f

Browse files
Merge pull request #1704 from glimmerjs/fix-types-rollup
Fix types rollup
2 parents cb9c617 + bc31a41 commit ad7f15f

File tree

4 files changed

+21
-22
lines changed

4 files changed

+21
-22
lines changed

.github/workflows/plan-release.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ jobs:
6060
- name: "Generate Explanation and Prep Changelogs"
6161
id: explanation
6262
run: |
63-
# Don't forget to-re-add these when we update release-plan
64-
pnpm repo:update:conventions
65-
pnpm repo:update:metadata
66-
6763
# Original Content Here
6864
set +e
6965
pnpm release-plan prepare 2> >(tee -a release-plan-stderr.txt >&2)
@@ -79,6 +75,9 @@ jobs:
7975
rm release-plan-stderr.txt
8076
fi
8177
78+
# Don't forget to-re-add these when we update release-plan
79+
pnpm repo:update:conventions
80+
pnpm repo:update:metadata
8281
8382
env:
8483
GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}

packages/@glimmer-workspace/build/lib/config.js

+1
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,7 @@ export class Package {
410410
output: {
411411
dir: `dist/${env}`,
412412
},
413+
external: this.#external,
413414
plugins: [
414415
dts({
415416
respectExternal: true,
+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# @glimmer/interfaces
22

3-
4-
Common interfaces shared among all @glimmer/* projects
3+
Common interfaces shared among all @glimmer/\* projects
54

65
(solving the diamond dependency problem)

repo-metadata/metadata.json

+16-16
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@
167167
{
168168
"root": "packages/@glimmer/compiler",
169169
"name": "@glimmer/compiler",
170-
"version": "0.94.4",
170+
"version": "0.94.5",
171171
"type": "module",
172172
"private": false,
173173
"repo-meta": {
@@ -275,7 +275,7 @@
275275
{
276276
"root": "packages/@glimmer/destroyable",
277277
"name": "@glimmer/destroyable",
278-
"version": "0.94.3",
278+
"version": "0.94.4",
279279
"type": "module",
280280
"private": false,
281281
"repo-meta": {
@@ -301,7 +301,7 @@
301301
{
302302
"root": "packages/@glimmer/encoder",
303303
"name": "@glimmer/encoder",
304-
"version": "0.93.3",
304+
"version": "0.93.4",
305305
"type": "module",
306306
"private": false,
307307
"repo-meta": {
@@ -327,7 +327,7 @@
327327
{
328328
"root": "packages/@glimmer/interfaces",
329329
"name": "@glimmer/interfaces",
330-
"version": "0.94.2",
330+
"version": "0.94.3",
331331
"type": "module",
332332
"private": false,
333333
"repo-meta": {
@@ -367,7 +367,7 @@
367367
{
368368
"root": "packages/@glimmer/manager",
369369
"name": "@glimmer/manager",
370-
"version": "0.94.3",
370+
"version": "0.94.4",
371371
"type": "module",
372372
"private": false,
373373
"repo-meta": {
@@ -394,7 +394,7 @@
394394
{
395395
"root": "packages/@glimmer/node",
396396
"name": "@glimmer/node",
397-
"version": "0.94.3",
397+
"version": "0.94.4",
398398
"type": "module",
399399
"private": false,
400400
"repo-meta": {
@@ -407,7 +407,7 @@
407407
{
408408
"root": "packages/@glimmer/opcode-compiler",
409409
"name": "@glimmer/opcode-compiler",
410-
"version": "0.94.3",
410+
"version": "0.94.4",
411411
"type": "module",
412412
"private": false,
413413
"repo-meta": {
@@ -446,7 +446,7 @@
446446
{
447447
"root": "packages/@glimmer/program",
448448
"name": "@glimmer/program",
449-
"version": "0.94.3",
449+
"version": "0.94.4",
450450
"type": "module",
451451
"private": false,
452452
"repo-meta": {
@@ -472,7 +472,7 @@
472472
{
473473
"root": "packages/@glimmer/reference",
474474
"name": "@glimmer/reference",
475-
"version": "0.94.3",
475+
"version": "0.94.4",
476476
"type": "module",
477477
"private": false,
478478
"repo-meta": {
@@ -498,7 +498,7 @@
498498
{
499499
"root": "packages/@glimmer/runtime",
500500
"name": "@glimmer/runtime",
501-
"version": "0.94.3",
501+
"version": "0.94.4",
502502
"type": "module",
503503
"private": false,
504504
"repo-meta": {
@@ -511,7 +511,7 @@
511511
{
512512
"root": "packages/@glimmer/syntax",
513513
"name": "@glimmer/syntax",
514-
"version": "0.94.3",
514+
"version": "0.94.4",
515515
"type": "module",
516516
"private": false,
517517
"repo-meta": {
@@ -537,7 +537,7 @@
537537
{
538538
"root": "packages/@glimmer/util",
539539
"name": "@glimmer/util",
540-
"version": "0.94.3",
540+
"version": "0.94.4",
541541
"type": "module",
542542
"private": false,
543543
"repo-meta": {
@@ -563,7 +563,7 @@
563563
{
564564
"root": "packages/@glimmer/validator",
565565
"name": "@glimmer/validator",
566-
"version": "0.94.3",
566+
"version": "0.94.4",
567567
"type": "module",
568568
"private": false,
569569
"repo-meta": {
@@ -590,7 +590,7 @@
590590
{
591591
"root": "packages/@glimmer/vm",
592592
"name": "@glimmer/vm",
593-
"version": "0.94.3",
593+
"version": "0.94.4",
594594
"type": "module",
595595
"private": false,
596596
"repo-meta": {
@@ -603,7 +603,7 @@
603603
{
604604
"root": "packages/@glimmer/vm-babel-plugins",
605605
"name": "@glimmer/vm-babel-plugins",
606-
"version": "0.93.2",
606+
"version": "0.93.3",
607607
"type": "module",
608608
"private": false,
609609
"repo-meta": {
@@ -616,7 +616,7 @@
616616
{
617617
"root": "packages/@glimmer/wire-format",
618618
"name": "@glimmer/wire-format",
619-
"version": "0.94.3",
619+
"version": "0.94.4",
620620
"type": "module",
621621
"private": false,
622622
"repo-meta": {

0 commit comments

Comments
 (0)