Merge pull request #1539 from glimmerjs/drop-ie11-code

Drop ie11 code

Author: NullVoxPopuli

packages/@glimmer-workspace/integration-tests/lib/suites/initial-render.ts

@@ -1060,12 +1060,12 @@ export class InitialRenderSuite extends RenderTest {
   @test
   'Integer powers of 2'() {
     const ints = [];
-    let i = 9007199254740991; // Number.MAX_SAFE_INTEGER isn't available on IE11
+    let i = Number.MAX_SAFE_INTEGER;
     while (i > 1) {
       ints.push(i);
       i = Math.round(i / 2);
     }
-    i = -9007199254740991; // Number.MIN_SAFE_INTEGER isn't available on IE11
+    i = Number.MIN_SAFE_INTEGER;
     while (i < -1) {
       ints.push(i);
       i = Math.round(i / 2);

packages/@glimmer-workspace/integration-tests/test/chaos-rehydration-test.ts

@@ -26,11 +26,6 @@ import {
   test,
 } from '..';
 
-// `window.ActiveXObject` is "falsey" in IE11 (but not `undefined` or `false`)
-// `"ActiveXObject" in window` returns `true` in all IE versions
-// only IE11 will pass _both_ of these conditions
-const isIE11 = !(window as any).ActiveXObject && 'ActiveXObject' in window;
-
 abstract class AbstractChaosMonkeyTest extends RenderTest {
   abstract renderClientSide(template: string | ComponentBlueprint, context: Dict<unknown>): void;
 
@@ -247,13 +242,7 @@ class ChaosMonkeyRehydration extends AbstractChaosMonkeyTest {
     const b = blockStack();
 
     // assert that we are in a "browser corrected" state (note the `</p>` before the `<div>world!</div>`)
-    if (isIE11) {
-      // IE11 doesn't behave the same as modern browsers
-      this.assertServerOutput(`<p>hello ${b(1)}<div>world!</div>${b(1)}<p></p>`);
-    } else {
-      this.assertServerOutput(`<p>hello ${b(1)}</p><div>world!</div>${b(1)}<p></p>`);
-    }
-
+    this.assertServerOutput(`<p>hello ${b(1)}</p><div>world!</div>${b(1)}<p></p>`);
     this.runIterations(template, context, '<p>hello <div>world!</div></p>', 100);
   }
 }

packages/@glimmer-workspace/integration-tests/test/initial-render-test.ts

@@ -29,11 +29,6 @@ import {
   toTextContent,
 } from '..';
 
-// `window.ActiveXObject` is "falsey" in IE11 (but not `undefined` or `false`)
-// `"ActiveXObject" in window` returns `true` in all IE versions
-// only IE11 will pass _both_ of these conditions
-const isIE11 = !(window as any).ActiveXObject && 'ActiveXObject' in window;
-
 class RenderTests extends InitialRenderSuite {
   static override suiteName = 'initial render (client)';
   override name = 'client';
@@ -1062,13 +1057,7 @@ class RehydratingComponents extends AbstractRehydrationTests {
 
     let id = this.testType === 'Dynamic' ? 3 : 2;
 
-    // assert that we are in a "browser corrected" state (note the `</p>` before the `<div>world!</div>`)
-    if (isIE11) {
-      // IE11 doesn't behave the same as modern browsers
-      this.assertServerComponent(`<p>hello ${b(id)}<div>world!</div>${b(id)}<p></p>`);
-    } else {
-      this.assertServerComponent(`<p>hello ${b(id)}</p><div>world!</div>${b(id)}<p></p>`);
-    }
+    this.assertServerComponent(`<p>hello ${b(id)}</p><div>world!</div>${b(id)}<p></p>`);
 
     this.renderClientSide(componentToRender, { show: true });
     this.assertComponent('<p>hello <div>world!</div></p>');

packages/@glimmer-workspace/integration-tests/test/modifiers/on-test.ts

@@ -31,7 +31,6 @@ const isChrome = hasDom
   ? typeof global.chrome === 'object' && !(typeof global.opera === 'object')
   : false;
 const isFirefox = hasDom ? /Firefox|FxiOS/u.test(navigator.userAgent) : false;
-const isIE11 = !global.ActiveXObject && 'ActiveXObject' in window;
 
 interface Counters {
   adds: number;
@@ -82,8 +81,6 @@ if (hasDom) {
 
       if (isChrome || isFirefox) {
         assert.strictEqual(SUPPORTS_EVENT_OPTIONS, true, 'is true in chrome and firefox');
-      } else if (isIE11) {
-        assert.strictEqual(SUPPORTS_EVENT_OPTIONS, false, 'is false in IE11');
       }
     }
 
@@ -189,11 +186,7 @@ if (hasDom) {
 
       assert.strictEqual(count, 1, 'has been called 1 times');
 
-      if (isIE11) {
-        this.assertCounts({ adds: 1, removes: 1 });
-      } else {
-        this.assertCounts({ adds: 1, removes: 0 });
-      }
+      this.assertCounts({ adds: 1, removes: 0 });
     }
 
     @test
@@ -226,11 +219,7 @@ if (hasDom) {
       button.click();
       assert.strictEqual(count, 3, 'is not called again');
 
-      if (isIE11) {
-        this.assertCounts({ adds: 2, removes: 2 });
-      } else {
-        this.assertCounts({ adds: 2, removes: 1 });
-      }
+      this.assertCounts({ adds: 2, removes: 1 });
     }
 
     @test

packages/@glimmer/debug/lib/metadata.ts

@@ -197,7 +197,7 @@ export function strip(strings: TemplateStringsArray, ...args: unknown[]) {
   // eslint-disable-next-line regexp/no-super-linear-backtracking
   out = /^\s*?\n?([\s\S]*?)\s*$/u.exec(out)![1] as string;
 
-  let min = 9007199254740991; // Number.MAX_SAFE_INTEGER isn't available on IE11
+  let min = Number.MAX_SAFE_INTEGER;
 
   for (let line of out.split('\n')) {
     let leading = /^\s*/u.exec(line)![0].length;

packages/@glimmer/runtime/lib/dom/sanitized-values.ts

@@ -78,12 +78,7 @@ function findProtocolForURL() {
       }
     };
   } else {
-    // fallback for IE11 support
-    let parsingNode = document.createElement('a');
-    return (url: string) => {
-      parsingNode.href = url;
-      return parsingNode.protocol;
-    };
+    throw new Error(`@glimmer/runtime needs a valid "globalThis.URL"`);
   }
 }
 

packages/@glimmer/util/test/debug-to-string-test.ts

@@ -1,8 +1,4 @@
 import { debugToString as maybeDebugToString } from '@glimmer/util';
-// `window.ActiveXObject` is "falsey" in IE11 (but not `undefined` or `false`)
-// `"ActiveXObject" in window` returns `true` in all IE versions
-// only IE11 will pass _both_ of these conditions
-const isIE11 = !(window as any).ActiveXObject && 'ActiveXObject' in window;
 
 QUnit.module('debug-to-string tests');
 
@@ -37,11 +33,9 @@ if (import.meta.env.DEV) {
   QUnit.test('should return debug name for primitive [Infinity]', (assert) => {
     assert.deepEqual(debugToString(Infinity), 'Infinity');
   });
-  if (!isIE11) {
-    QUnit.test('should return debug name for primitive [Symbol]', (assert) => {
-      assert.deepEqual(debugToString(Symbol('Foo')), 'Symbol(Foo)');
-    });
-  }
+  QUnit.test('should return debug name for primitive [Symbol]', (assert) => {
+    assert.deepEqual(debugToString(Symbol('Foo')), 'Symbol(Foo)');
+  });
   QUnit.test('should return debug name for object', (assert) => {
     assert.deepEqual(debugToString({}), 'Object');
   });

packages/@glimmer/validator/lib/debug.ts

@@ -171,8 +171,7 @@ if (import.meta.env.DEV) {
       current = current.parent;
     }
 
-    // TODO: Use String.prototype.repeat here once we can drop support for IE11
-    return trackingStack.map((label, index) => Array(2 * index + 1).join(' ') + label).join('\n');
+    return trackingStack.map((label, index) => ' '.repeat(2 * index) + label).join('\n');
   };
 
   debug.markTagAsConsumed = (_tag: Tag) => {