Skip to content

Commit da5ebb9

Browse files
Merge pull request #1711 from glimmerjs/pull-bench-stuf-out
Pull benchmark changes from feature/emit-fn-calls
2 parents 33cb374 + 1ec781e commit da5ebb9

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

benchmark/benchmarks/krausest/package.json

+2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,10 @@
3939
"@glimmer/opcode-compiler": "file:packages/@glimmer/opcode-compiler.tgz",
4040
"@glimmer/program": "file:packages/@glimmer/program.tgz",
4141
"@glimmer/reference": "file:packages/@glimmer/reference.tgz",
42+
"@glimmer/syntax": "file:packages/@glimmer/syntax.tgz",
4243
"@glimmer/util": "file:packages/@glimmer/util.tgz",
4344
"@glimmer/validator": "file:packages/@glimmer/validator.tgz",
45+
"@glimmer/wire-format": "file:packages/@glimmer/wire-format.tgz",
4446
"@glimmer-workspace/env": "file:packages/@glimmer-workspace/env.tgz"
4547
}
4648
}

bin/setup-bench.mts

+15-11
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ $.verbose = true;
1919
* can be used to reuse the checked out control branch.
2020
*/
2121
const FRESH_CONTROL_CHECKOUT = !process.env['REUSE_CONTROL'];
22+
const FRESH_EXPERIMENT_CHECKOUT = !process.env['REUSE_EXPERIMENT'];
2223

2324
/*
2425
@@ -93,16 +94,18 @@ const pnpm = await which('pnpm');
9394

9495
// set up experiment
9596
{
96-
await $`rm -rf ${EXPERIMENT_DIRS.root}`;
97-
await $`mkdir -p ${EXPERIMENT_DIRS.bench}`;
98-
await $`cp -r ${EXPERIMENT_DIRS.src}/* ${EXPERIMENT_DIRS.bench}/`;
99-
await $`${pnpm} build --output-logs=new-only`;
100-
await buildKrausestDeps({
101-
roots: { benchmark: EXPERIMENT_DIRS.bench, workspace: WORKSPACE_ROOT },
102-
});
103-
await $`rm -rf ${EXPERIMENT_DIRS.bench}/node_modules`;
104-
await $({ cwd: EXPERIMENT_DIRS.bench })`${pnpm} install`;
105-
await $({ cwd: EXPERIMENT_DIRS.bench })`${pnpm} vite build`;
97+
if (FRESH_EXPERIMENT_CHECKOUT) {
98+
await $`rm -rf ${EXPERIMENT_DIRS.root}`;
99+
await $`mkdir -p ${EXPERIMENT_DIRS.bench}`;
100+
await $`cp -r ${EXPERIMENT_DIRS.src}/* ${EXPERIMENT_DIRS.bench}/`;
101+
await $`${pnpm} turbo prepack --output-logs=new-only`;
102+
await buildKrausestDeps({
103+
roots: { benchmark: EXPERIMENT_DIRS.bench, workspace: WORKSPACE_ROOT },
104+
});
105+
await $`rm -rf ${EXPERIMENT_DIRS.bench}/node_modules`;
106+
await $({ cwd: EXPERIMENT_DIRS.bench })`${pnpm} install`;
107+
await $({ cwd: EXPERIMENT_DIRS.bench })`${pnpm} vite build`;
108+
}
106109
}
107110

108111
// make sure that the origin is up to date so we get the right control
@@ -139,10 +142,11 @@ console.info({
139142
await $`rm -rf ${CONTROL_DIRS.bench}`;
140143
// Intentionally use the `krausest` folder from the experiment in both
141144
// control and experiment
145+
await $`mkdir -p ${CONTROL_DIRS.bench}`;
142146
await $`cp -r ${EXPERIMENT_DIRS.src}/* ${CONTROL_DIRS.bench}/`;
143147

144148
await $({ cwd: CONTROL_DIRS.repo })`${pnpm} install`;
145-
await $({ cwd: CONTROL_DIRS.repo })`${pnpm} build --output-logs=new-only`;
149+
await $({ cwd: CONTROL_DIRS.repo })`${pnpm} turbo prepack --output-logs=new-only`;
146150

147151
const benchmarkEnv = join(CONTROL_DIRS.repo, 'packages/@glimmer-workspace/benchmark-env');
148152

0 commit comments

Comments
 (0)