Skip to content

Commit ddfb5f0

Browse files
committed
Don't try to fix dynamic modifiers yet
This case is not fixed by the current PR: ``` <p {{some.modifier}}> ``` It probably *should* result in `some.modifier` appearing as the `name` in the debug modifier tree, but the codepaths improved in the current PR don't fix that case. For this PR, we'll use the debug name provided by the modifier manager, which is at least not a regression. A future PR should systematically fix all of the cases that end up in the debug tree so that they *always* show "what the user typed", regardless of how it got converted into running code.
1 parent b665241 commit ddfb5f0

File tree

1 file changed

+1
-1
lines changed
  • packages/@glimmer/opcode-compiler/lib/opcode-builder/helpers

1 file changed

+1
-1
lines changed

packages/@glimmer/opcode-compiler/lib/opcode-builder/helpers/resolution.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ export function resolveModifier(
216216
);
217217
}
218218

219-
then(constants.modifier(modifier, name));
219+
then(constants.modifier(modifier));
220220
}
221221
}
222222

0 commit comments

Comments
 (0)