Re-add support for tsconfig's moduleResolution=node10 #1741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels crazy to add support for the node10 moduleResolution setting, but as pointed out in:
emberjs/ember.js#20876
Some projects aren't up to date enough to use more modern moduleResolution settings -- and every TS dep needs to be compat with both in order to allow a consumer to migrate.
From the tsconfig docs
No one should be using Node10 if they're writing ESM.
moduleResolution: node
was renamed tomoduleResolution: node10
with the release of TypeScript 5.0, which was released in March of 2023, which at the time, ember LTS was 4.8 with 4.12 being released on May 2023.So it is within the TS Rolling support policy to be reasonable to have dropped support for
moduleResolution: node10
, and earlier TS versions.(assuming config changes't aren't covered under semver-ts -- I opened this issue on semver-ts)
However, supporting node10 is easy, as this PR is one line change in each published package.json