Fix: Undefined array key on Asset import

[eduardomozart]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes # (issue number, if applicable)
• Here is a brief description of what this PR does

Screenshots (if appropriate):

The error "Undefined array key" is thrown on GLPI-Agent 1.12 when importing Inventory from a Windows machine when modifying the "Computer update (by serial + uuid)" from "Link if possible" (default) to "Link if possible, otherwise imports declined".

I did a error_log(print_r($datarules, true)) before the if call and it returns the following:

(
    [rules_id] => 247
    [_ruleid] => 247
)

This ID reflects the rule Computer update (by serial + uuid) which refers to the Rule where it stopped and the asset hasn't been imported. Notice that there's no action key on the array. This PR do the action validation only if it's set.

The machine doesn't exist on the glpi_computers DB (it existed before but has been deleted). The inventory file of this machine is in attachment.

computer_0_46.json
rules.xml.txt

[stonebuzz]

Hi @eduardomozart,

I successfully completed the first import without any issues or Undefined array key. I then adjusted the rule accordingly.

The second import also ran without any errors.

Could you provide me with an export of your computer rules?

[trasher]

A test case to reproduce is needed

[eduardomozart]

Hello @trasher and @stonebuzz, I've updated the inventory file and exported the rules XML file as requested and was able to reproduce the issue by importing the inventory file manually. Please make sure to attempt to import the file with the GLPI Debug mode enabled and PHP display_errors directive set to 'On'. It states "File has been successfully imported" but I think that for "Import denied (no log)" it should also return as refused because it can confuse the user, as in fact the Computer asset hasn't been imported.

[stonebuzz]

Always nothing on my side

[stonebuzz]

Could you try again by resetting your rules?

[eduardomozart]

If I reset the rules it should work as expected since it happens only when the rule Computer update (by serial + uuid) is set to Link if possible, otherwise import denied. Did the asset has been created for you? I deleted it without keeping associated devices, changed the rule and it hasn't been imported for me at all. Please also make sure that your Administration > Inventory > Virtualization settings is as below: