improved append test and added more append deep copies

Author: deelawn

gno.land/cmd/gnoland/testdata/append.txtar

@@ -39,6 +39,27 @@ gnokey maketx call -pkgpath gno.land/r/append -func Render -gas-fee 1000000ugnot
 stdout '("2-3-42-" string)'
 stdout OK!
 
+gnokey maketx call -pkgpath gno.land/r/append -func CopyAppend -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+gnokey maketx call -pkgpath gno.land/r/append -func PopB -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+# Call render
+gnokey maketx call -pkgpath gno.land/r/append -func Render -gas-fee 1000000ugnot -gas-wanted 2000000 -args '' -broadcast -chainid=tendermint_test test1
+stdout '("2-3-42-" string)'
+stdout OK!
+
+gnokey maketx call -pkgpath gno.land/r/append -func AppendMoreAndC -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+gnokey maketx call -pkgpath gno.land/r/append -func ReassignC -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+gnokey maketx call -pkgpath gno.land/r/append -func Render -gas-fee 1000000ugnot -gas-wanted 2000000 -args '' -broadcast -chainid=tendermint_test test1
+stdout '("2-3-42-70-100-" string)'
+stdout OK!
+
 -- append.gno --
 package append
 
@@ -48,7 +69,9 @@ import (
 
 type T struct{ i int }
 
-var a []T
+var a, b []T
+var c = []T{{i: 100}}
+
 
 func init() {
 	a = make([]T, 0, 1)
@@ -62,6 +85,25 @@ func Append(i int) {
 	a = append(a, T{i: i})
 }
 
+func CopyAppend() {
+	b = append(a, T{i: 50}, T{i: 60})
+}
+
+func PopB() {
+	b = append(b[:0], b[1:]...)
+}
+
+func AppendMoreAndC() {
+	// Fill to capacity
+	a = append(a, T{i: 70})
+	// Above capacity; make new array
+	a = append(a, c...)
+}
+
+func ReassignC() {
+	c[0] = T{i: 200}
+}
+
 func Render(path string) string {
 	var s string
 	for i:=0;i<len(a);i++{

gnovm/pkg/gnolang/uverse.go

@@ -376,7 +376,7 @@ func UverseNode() *PackageNode {
 						if 0 < xvl {
 							if xvb.Data == nil {
 								for i := 0; i < xvl; i++ {
-									list[i] = xvb.List[xvo+i].Copy(m.Alloc)
+									list[i] = xvb.List[xvo+i].DeepCopy(m.Alloc, m.Store)
 								}
 							} else {
 								panic("should not happen")
@@ -392,7 +392,7 @@ func UverseNode() *PackageNode {
 						if 0 < argsl {
 							if argsb.Data == nil {
 								for i := 0; i < argsl; i++ {
-									list[xvl+i] = argsb.List[argso+i].Copy(m.Alloc)
+									list[xvl+i] = argsb.List[argso+i].DeepCopy(m.Alloc, m.Store)
 								}
 							} else {
 								copyDataToList(

gnovm/tests/files/a47.gno

@@ -0,0 +1,32 @@
+package main
+
+type S struct {
+	i int
+}
+
+func main() {
+	sArr := make([]S, 0, 4)
+	sArr = append(sArr, S{1}, S{2}, S{3})
+	println(sArr[0].i, sArr[1].i, sArr[2].i)
+
+	newArr := append(sArr[:0], sArr[1:]...)
+
+	// The append modified the underlying array because it was within capacity.
+	println(len(sArr) == 3)
+	println(sArr[0].i, sArr[1].i, sArr[2].i)
+
+	// It generated a new slice that references the same array.
+	println(len(newArr) == 2)
+	println(newArr[0].i, newArr[1].i)
+
+	// The struct should have been copied, not referenced.
+	println(&sArr[2] != &newArr[1])
+}
+
+// Output:
+// 1 2 3
+// true
+// 2 3 3
+// true
+// 2 3
+// true