Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code search exact makes not exact search #33713

Open
gomanuke opened this issue Feb 25, 2025 · 5 comments
Open

Code search exact makes not exact search #33713

gomanuke opened this issue Feb 25, 2025 · 5 comments
Labels
Milestone

Comments

@gomanuke
Copy link

Description

Here You are a file that returns by "GetPrev" search string.
IMHO exact searching must not return it.

prompt --application/shared_components/user_interface/shortcuts/ok_to_get_next_prev_pk_value begin -- Manifest -- SHORTCUT: OK_TO_GET_NEXT_PREV_PK_VALUE -- Manifest End wwv_flow_imp.component_begin ( p_version_yyyy_mm_dd=>'2024.05.31' ,p_release=>'24.1.7' ,p_default_workspace_id=>1202104075024633 ,p_default_application_id=>401 ,p_default_id_offset=>8704503425691951 ,p_default_owner=>'OBLAKO_PRINT' ); wwv_flow_imp_shared.create_shortcut( p_id=>wwv_flow_imp.id(26669283042465176847) ,p_shortcut_name=>'OK_TO_GET_NEXT_PREV_PK_VALUE' ,p_shortcut_type=>'TEXT_ESCAPE_JS' ,p_version_scn=>1 ,p_shortcut=>'Are you sure you want to leave this page without saving?' ); wwv_flow_imp.component_end; end; /

Gitea Version

1.23.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian 12

How are you running Gitea?

systemctl daemon

Database

MySQL/MariaDB

@wxiaoguang
Copy link
Contributor

@6543 need to remove the "fuzzy"?

@gomanuke
Copy link
Author

gomanuke commented Feb 25, 2025

Exact is by default:

Image

@jpraet
Copy link
Member

jpraet commented Feb 25, 2025

Possibly resolved by #33628 which restores the search mode for bleve from MatchQuery back to MatchPhraseQuery, as it was in 1.22.

On the main branch though, it is still using MatchQuery, but with #33590 a "literal search mode" was added (by using quotes).

@gomanuke
Copy link
Author

gomanuke commented Feb 26, 2025

Appreciate You for explanation. Using quotes is definitely solution.
Would You clarify about release practice: when we can get binary with #33590 ?

@lunny lunny added this to the 1.23.5 milestone Feb 26, 2025
@lunny
Copy link
Member

lunny commented Feb 26, 2025

#33628 will be released in v1.23.5 and #33590 will be released in v1.24.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants