Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix omitempty bug #33663

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix omitempty bug #33663

merged 1 commit into from
Feb 20, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 20, 2025

Fix #33660

@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Feb 20, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2025
ChristopherHX
ChristopherHX approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is correct now, for further info
Retrieved here

gitea/routers/web/repo/migrate.go

Line 314 in 3ee5ee2

var translatableMessage admin_model.TranslatableMessage

Stored here in database as string with wrong key

gitea/services/task/migrate.go

Line 130 in 3ee5ee2

_ = t.UpdateCols(ctx, "message")

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2025
@lunny lunny merged commit a25081f into go-gitea:main Feb 20, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 20, 2025
@lunny lunny deleted the lunny/fix_omitempty_bug branch February 20, 2025 20:39
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 21, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
681ec25 
* giteaofficial/main:
  Fix omitempty bug (go-gitea#33663)
  Upgrade golangci-lint to v1.64.5 (go-gitea#33654)
  Fix mCaptcha bug (go-gitea#33659)
  Update Go dependencies (skip blevesearch, meilisearch) (go-gitea#33655)
  Use test context in tests and new loop system in benchmarks (go-gitea#33648)
  Add missed changelogs (go-gitea#33649)
  [skip ci] Updated translations via Crowdin
  git graph: don't show detached commits (go-gitea#33645)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 21, 2025
@lunny @GiteaBot
Fix omitempty bug (go-gitea#33663)
f58b567 
Fix go-gitea#33660
@GiteaBot GiteaBot mentioned this pull request Feb 21, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 21, 2025
lunny added a commit that referenced this pull request Feb 21, 2025
@GiteaBot @lunny
Fix omitempty bug (#33663) (#33670)
37e99d9 
Backport #33663 by @lunny

Fix #33660

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

JSON tag uses "omitempty" as the field name
4 participants
@lunny @techknowlogick @ChristopherHX @GiteaBot