Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve swagger generation #33664

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Improve swagger generation #33664

merged 6 commits into from
Feb 21, 2025

Conversation

wxiaoguang
Copy link
Contributor

Remove most "sed" tricks

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/internal labels Feb 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2025
@silverwind
Copy link
Member

Also update

[templates/swagger/v1_json.tmpl]
to match the second JSON file.

@ChristopherHX
Copy link
Contributor

Running gopls check...
templates/swagger/v1_json.tmpl:
Wrong line endings or no final newline

1 errors found
exit status 1

This seems to be the additional linter that demands a lf at the end

@silverwind
Copy link
Member

silverwind commented Feb 20, 2025

And update here as well:

- "templates/swagger/v1_json.tmpl"

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Feb 21, 2025

Also update editorconfig#L18 to match the second JSON file.

No need to change that. By default, "JSON" uses "space". That line is for "tmpl" only.

And update here as well: .github/workflows/files-changed.yml#L87

Done

This seems to be the additional linter that demands a lf at the end

Yep, it's from the editorconfig check. The linters fight with each other .....


Tried to fix the above problems in 8d8eac8 , now all linters pass

wxiaoguang and others added 2 commits February 21, 2025 14:56
Co-authored-by: silverwind <me@silverwind.io>
@lunny lunny merged commit 4adb7ca into go-gitea:main Feb 21, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 21, 2025
@wxiaoguang wxiaoguang deleted the fix-swagger-gen branch February 21, 2025 08:20
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2025
* giteaofficial/main:
  Fix git empty check and HEAD request (go-gitea#33690)
  Fix some user name usages (go-gitea#33689)
  Try to fix ACME path when renew (go-gitea#33668)
  [skip ci] Updated translations via Crowdin
  Improve Open-with URL encoding (go-gitea#33666)
  Fix for Maven Package Naming Convention Handling (go-gitea#33678)
  Improve swagger generation (go-gitea#33664)
  Deleting repository should unlink all related packages (go-gitea#33653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/internal modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants