Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Open-with URL encoding #33666

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Improve Open-with URL encoding #33666

merged 4 commits into from
Feb 21, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33665

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2025
@wxiaoguang wxiaoguang mentioned this pull request Feb 21, 2025
Closed
@wxiaoguang wxiaoguang added backport/v1.23 This PR should be backported to Gitea 1.23 type/bug labels Feb 21, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2025
delvh
delvh approved these changes Feb 21, 2025
View reviewed changes
web_src/js/features/repo-common.test.ts
import {substituteRepoOpenWithUrl} from './repo-common.ts';

test('substituteRepoOpenWithUrl', () => {
expect(substituteRepoOpenWithUrl('proto://a/{url}', 'https://gitea')).toEqual('proto://a/https://gitea');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm, what?
Is that really a valid URL?
It looks wrong to me…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is not a URL since the "protocol" is not http(s).

There is no requirement to encode that part.

image

Copy link
Member

@silverwind silverwind Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is a valid URL according to URL standard:

> new URL("proto://a/https://gitea")
URL {
  href: 'proto://a/https://gitea',
  origin: 'null',
  protocol: 'proto:',
  username: '',
  password: '',
  host: 'a',
  hostname: 'a',
  port: '',
  pathname: '/https://gitea',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2025
@silverwind
Copy link
Member

BTW could move the function to web_src/js/utils/url.ts.

@wxiaoguang
Copy link
Contributor Author

BTW could move the function to web_src/js/utils/url.ts.

Please do not do that. This function is specialized for the "open-with" links only, it doesn't make sense to move it to a global TS file.

@wxiaoguang wxiaoguang enabled auto-merge (squash) February 21, 2025 17:41
@wxiaoguang wxiaoguang merged commit ead716d into go-gitea:main Feb 21, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 21, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 21, 2025
@wxiaoguang @GiteaBot
Improve Open-with URL encoding (go-gitea#33666)
f94165d 
Fix go-gitea#33665
@GiteaBot GiteaBot mentioned this pull request Feb 21, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 21, 2025
@wxiaoguang wxiaoguang deleted the improve-open-with-encode branch February 21, 2025 17:47
wxiaoguang added a commit that referenced this pull request Feb 21, 2025
@GiteaBot @wxiaoguang
Improve Open-with URL encoding (#33666) (#33680)
ae595aa 
Backport #33666 by wxiaoguang

Fix #33665

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
debdd78 
* giteaofficial/main:
  Fix git empty check and HEAD request (go-gitea#33690)
  Fix some user name usages (go-gitea#33689)
  Try to fix ACME path when renew (go-gitea#33668)
  [skip ci] Updated translations via Crowdin
  Improve Open-with URL encoding (go-gitea#33666)
  Fix for Maven Package Naming Convention Handling (go-gitea#33678)
  Improve swagger generation (go-gitea#33664)
  Deleting repository should unlink all related packages (go-gitea#33653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Open with <IDE> x-github-client expects full-uri
5 participants
@wxiaoguang @silverwind @lunny @delvh @GiteaBot