Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove not recommended gorilla context #7820

Closed
wants to merge 3 commits into from

Conversation

sapk
Copy link
Member

@sapk sapk commented Aug 10, 2019

Try to remove references to https://github.com/gorilla/context

Still a wip since it may need to update other deps.

@codecov-io
Copy link

Codecov Report

Merging #7820 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7820      +/-   ##
==========================================
- Coverage   41.42%   41.42%   -0.01%     
==========================================
  Files         474      474              
  Lines       63876    63876              
==========================================
- Hits        26460    26459       -1     
- Misses      33971    33974       +3     
+ Partials     3445     3443       -2
Impacted Files Coverage Δ
cmd/web.go 0% <0%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d2c25...9e66515. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 10, 2019
@typeless
Copy link
Contributor

Is this still WIP?

@sapk
Copy link
Member Author

sapk commented Aug 21, 2019

Yes since in the background it does some magic for other deps like xormstore. I have a WIP to use a more standard way there lafriks/xormstore#8.

@stale
Copy link

stale bot commented Oct 20, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 20, 2019
@stale
Copy link

stale bot commented Dec 19, 2019

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this Dec 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants